linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Shaohua Li <shaohua.li@intel.com>
To: linux-mm <linux-mm@kvack.org>
Cc: hannes@cmpxchg.org, riel@redhat.com,
	Andrew Morton <akpm@linux-foundation.org>,
	"Wu, Fengguang" <fengguang.wu@intel.com>
Subject: [patch]vmscan: protect exectuable page from inactive list scan
Date: Wed, 29 Sep 2010 10:57:40 +0800	[thread overview]
Message-ID: <1285729060.27440.14.camel@sli10-conroe.sh.intel.com> (raw)

With commit 645747462435, pte referenced file page isn't activated in inactive
list scan. For VM_EXEC page, if it can't get a chance to active list, the
executable page protect loses its effect. We protect such page in inactive scan
here, now such page will be guaranteed cached in a full scan of active and
inactive list, which restores previous behavior.

Signed-off-by: Shaohua Li <shaohua.li@intel.com>

diff --git a/mm/vmscan.c b/mm/vmscan.c
index c5dfabf..b973048 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -608,8 +608,15 @@ static enum page_references page_check_references(struct page *page,
 		 * quickly recovered.
 		 */
 		SetPageReferenced(page);
-
-		if (referenced_page)
+		/*
+		 * Identify pte referenced and file-backed pages and give them
+		 * one trip around the active list. So that executable code get
+		 * better chances to stay in memory under moderate memory
+		 * pressure. JVM can create lots of anon VM_EXEC pages, so we
+		 * ignore them here.
+		 */
+		if (referenced_page || ((vm_flags & VM_EXEC) &&
+		    page_is_file_cache(page)))
 			return PAGEREF_ACTIVATE;
 
 		return PAGEREF_KEEP;


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2010-09-29  2:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-29  2:57 Shaohua Li [this message]
2010-09-29 10:17 ` [patch]vmscan: protect exectuable page from inactive list scan Johannes Weiner
2010-09-30  0:04   ` Shaohua Li
2010-09-30  2:27     ` KOSAKI Motohiro
2010-09-30  2:57       ` Wu Fengguang
2010-09-30  3:04         ` KOSAKI Motohiro
2010-09-30  3:20         ` Shaohua Li
2010-09-30  3:32           ` Wu Fengguang
2010-09-30  4:46           ` KOSAKI Motohiro
2010-09-30  5:46             ` Shaohua Li
2010-09-30  6:00               ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1285729060.27440.14.camel@sli10-conroe.sh.intel.com \
    --to=shaohua.li@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=fengguang.wu@intel.com \
    --cc=hannes@cmpxchg.org \
    --cc=linux-mm@kvack.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).