linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Gleb Natapov <gleb@redhat.com>
To: kvm@vger.kernel.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, avi@redhat.com,
	mingo@elte.hu, a.p.zijlstra@chello.nl, tglx@linutronix.de,
	hpa@zytor.com, riel@redhat.com, cl@linux-foundation.org,
	mtosatti@redhat.com
Subject: [PATCH v6 11/12] Let host know whether the guest can handle async PF in non-userspace context.
Date: Mon,  4 Oct 2010 17:56:33 +0200	[thread overview]
Message-ID: <1286207794-16120-12-git-send-email-gleb@redhat.com> (raw)
In-Reply-To: <1286207794-16120-1-git-send-email-gleb@redhat.com>

If guest can detect that it runs in non-preemptable context it can
handle async PFs at any time, so let host know that it can send async
PF even if guest cpu is not in userspace.

Acked-by: Rik van Riel <riel@redhat.com>
Signed-off-by: Gleb Natapov <gleb@redhat.com>
---
 Documentation/kvm/msr.txt       |    5 +++--
 arch/x86/include/asm/kvm_host.h |    1 +
 arch/x86/include/asm/kvm_para.h |    1 +
 arch/x86/kernel/kvm.c           |    3 +++
 arch/x86/kvm/x86.c              |    5 +++--
 5 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/Documentation/kvm/msr.txt b/Documentation/kvm/msr.txt
index d64e723..918f9ad 100644
--- a/Documentation/kvm/msr.txt
+++ b/Documentation/kvm/msr.txt
@@ -153,9 +153,10 @@ MSR_KVM_SYSTEM_TIME: 0x12
 
 MSR_KVM_ASYNC_PF_EN: 0x4b564d02
 	data: Bits 63-6 hold 64-byte aligned physical address of a 32bit memory
-	area which must be in guest RAM. Bits 5-1 are reserved and should be
+	area which must be in guest RAM. Bits 5-2 are reserved and should be
 	zero. Bit 0 is 1 when asynchronous page faults are enabled on the vcpu
-	0 when disabled.
+	0 when disabled. Bit 2 is 1 if asynchronous page faults can be injected
+	when vcpu is in kernel mode.
 
 	Physical address points to 32 bit memory location that will be written
 	to by the hypervisor at the time of asynchronous page fault injection to
diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
index 2f6fc87..81c1a4f 100644
--- a/arch/x86/include/asm/kvm_host.h
+++ b/arch/x86/include/asm/kvm_host.h
@@ -420,6 +420,7 @@ struct kvm_vcpu_arch {
 		struct gfn_to_hva_cache data;
 		u64 msr_val;
 		u32 id;
+		bool send_user_only;
 	} apf;
 };
 
diff --git a/arch/x86/include/asm/kvm_para.h b/arch/x86/include/asm/kvm_para.h
index bcc5022..bf3dab3 100644
--- a/arch/x86/include/asm/kvm_para.h
+++ b/arch/x86/include/asm/kvm_para.h
@@ -38,6 +38,7 @@
 #define KVM_MAX_MMU_OP_BATCH           32
 
 #define KVM_ASYNC_PF_ENABLED			(1 << 0)
+#define KVM_ASYNC_PF_SEND_ALWAYS		(1 << 1)
 
 /* Operations for KVM_HC_MMU_OP */
 #define KVM_MMU_OP_WRITE_PTE            1
diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
index f73946f..d5877bf 100644
--- a/arch/x86/kernel/kvm.c
+++ b/arch/x86/kernel/kvm.c
@@ -449,6 +449,9 @@ void __cpuinit kvm_guest_cpu_init(void)
 	if (kvm_para_has_feature(KVM_FEATURE_ASYNC_PF) && kvmapf) {
 		u64 pa = __pa(&__get_cpu_var(apf_reason));
 
+#ifdef CONFIG_PREEMPT
+		pa |= KVM_ASYNC_PF_SEND_ALWAYS;
+#endif
 		if (native_write_msr_safe(MSR_KVM_ASYNC_PF_EN,
 					  pa | KVM_ASYNC_PF_ENABLED, pa >> 32))
 			return;
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 0e69d37..cad4412 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -1429,8 +1429,8 @@ static int kvm_pv_enable_async_pf(struct kvm_vcpu *vcpu, u64 data)
 {
 	gpa_t gpa = data & ~0x3f;
 
-	/* Bits 1:5 are resrved, Should be zero */
-	if (data & 0x3e)
+	/* Bits 2:5 are resrved, Should be zero */
+	if (data & 0x3c)
 		return 1;
 
 	vcpu->arch.apf.msr_val = data;
@@ -1444,6 +1444,7 @@ static int kvm_pv_enable_async_pf(struct kvm_vcpu *vcpu, u64 data)
 	if (kvm_gfn_to_hva_cache_init(vcpu->kvm, &vcpu->arch.apf.data, gpa))
 		return 1;
 
+	vcpu->arch.apf.send_user_only = !(data & KVM_ASYNC_PF_SEND_ALWAYS);
 	kvm_async_pf_wakeup_all(vcpu);
 	return 0;
 }
-- 
1.7.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2010-10-04 15:56 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-04 15:56 [PATCH v6 00/12] KVM: Add host swap event notifications for PV guest Gleb Natapov
2010-10-04 15:56 ` [PATCH v6 01/12] Add get_user_pages() variant that fails if major fault is required Gleb Natapov
2010-10-04 15:56 ` [PATCH v6 02/12] Halt vcpu if page it tries to access is swapped out Gleb Natapov
2010-10-05  1:20   ` Rik van Riel
2010-10-05 14:59   ` Marcelo Tosatti
2010-10-06 10:50     ` Avi Kivity
2010-10-06 10:52       ` Gleb Natapov
2010-10-07  9:54         ` Avi Kivity
2010-10-07 17:48           ` Gleb Natapov
2010-10-06 11:15     ` Gleb Natapov
2010-10-07  9:50   ` Avi Kivity
2010-10-07  9:52     ` Avi Kivity
2010-10-07 13:24     ` Rik van Riel
2010-10-07 13:29       ` Avi Kivity
2010-10-07 17:47     ` Gleb Natapov
2010-10-09 18:30       ` Avi Kivity
2010-10-09 18:32         ` Avi Kivity
2010-10-10  7:30           ` Gleb Natapov
2010-10-10  7:29         ` Gleb Natapov
2010-10-10 15:55           ` Avi Kivity
2010-10-10 15:56             ` Avi Kivity
2010-10-10 16:17               ` Gleb Natapov
2010-10-10 16:16             ` Gleb Natapov
2010-10-04 15:56 ` [PATCH v6 03/12] Retry fault before vmentry Gleb Natapov
2010-10-05 15:54   ` Marcelo Tosatti
2010-10-06 11:07     ` Gleb Natapov
2010-10-06 14:20       ` Marcelo Tosatti
2010-10-07 18:44         ` Gleb Natapov
2010-10-08 16:07           ` Marcelo Tosatti
2010-10-07 12:29   ` Avi Kivity
2010-10-07 17:21     ` Gleb Natapov
2010-10-09 18:42       ` Avi Kivity
2010-10-10  7:35         ` Gleb Natapov
2010-10-04 15:56 ` [PATCH v6 04/12] Add memory slot versioning and use it to provide fast guest write interface Gleb Natapov
2010-10-05  1:29   ` Rik van Riel
2010-10-05 16:57   ` Marcelo Tosatti
2010-10-06 11:14     ` Gleb Natapov
2010-10-06 14:38       ` Marcelo Tosatti
2010-10-06 20:08         ` Gleb Natapov
2010-10-07 10:00           ` Avi Kivity
2010-10-07 15:42             ` Marcelo Tosatti
2010-10-07 16:03               ` Gleb Natapov
2010-10-07 16:20                 ` Avi Kivity
2010-10-07 17:23                   ` Gleb Natapov
2010-10-10 12:48                     ` Avi Kivity
2010-10-07 12:31   ` Avi Kivity
2010-10-04 15:56 ` [PATCH v6 05/12] Move kvm_smp_prepare_boot_cpu() from kvmclock.c to kvm.c Gleb Natapov
2010-10-04 15:56 ` [PATCH v6 06/12] Add PV MSR to enable asynchronous page faults delivery Gleb Natapov
2010-10-07 12:42   ` Avi Kivity
2010-10-07 17:53     ` Gleb Natapov
2010-10-10 12:47       ` Avi Kivity
2010-10-10 13:27         ` Gleb Natapov
2010-10-07 12:58   ` Avi Kivity
2010-10-07 17:59     ` Gleb Natapov
2010-10-09 18:43       ` Avi Kivity
2010-10-04 15:56 ` [PATCH v6 07/12] Add async PF initialization to PV guest Gleb Natapov
2010-10-05  2:34   ` Rik van Riel
2010-10-05 18:25   ` Marcelo Tosatti
2010-10-06 10:55     ` Gleb Natapov
2010-10-06 14:45       ` Marcelo Tosatti
2010-10-06 20:05         ` Gleb Natapov
2010-10-07 12:50   ` Avi Kivity
2010-10-08  7:54     ` Gleb Natapov
2010-10-09 18:44       ` Avi Kivity
2010-10-04 15:56 ` [PATCH v6 08/12] Handle async PF in a guest Gleb Natapov
2010-10-07 13:10   ` Avi Kivity
2010-10-07 17:14     ` Gleb Natapov
2010-10-07 17:18       ` Avi Kivity
2010-10-07 17:48         ` Rik van Riel
2010-10-07 18:03         ` Gleb Natapov
2010-10-09 18:48           ` Avi Kivity
2010-10-10  7:56             ` Gleb Natapov
2010-10-10 12:40               ` Avi Kivity
2010-10-10 12:32     ` Gleb Natapov
2010-10-10 12:38       ` Avi Kivity
2010-10-10 13:22         ` Gleb Natapov
2010-10-04 15:56 ` [PATCH v6 09/12] Inject asynchronous page fault into a PV guest if page is swapped out Gleb Natapov
2010-10-05  2:36   ` Rik van Riel
2010-10-05 19:00   ` Marcelo Tosatti
2010-10-06 10:42     ` Gleb Natapov
2010-10-04 15:56 ` [PATCH v6 10/12] Handle async PF in non preemptable context Gleb Natapov
2010-10-05 19:51   ` Marcelo Tosatti
2010-10-06 10:41     ` Gleb Natapov
2010-10-10 14:25       ` Gleb Natapov
2010-10-04 15:56 ` Gleb Natapov [this message]
2010-10-07 13:36   ` [PATCH v6 11/12] Let host know whether the guest can handle async PF in non-userspace context Avi Kivity
2010-10-04 15:56 ` [PATCH v6 12/12] Send async PF when guest is not in userspace too Gleb Natapov
2010-10-05  2:37   ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1286207794-16120-12-git-send-email-gleb@redhat.com \
    --to=gleb@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=avi@redhat.com \
    --cc=cl@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@elte.hu \
    --cc=mtosatti@redhat.com \
    --cc=riel@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).