From: Michel Lespinasse <walken@google.com>
To: linux-mm@kvack.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Ying Han <yinghan@google.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@redhat.com>, Nick Piggin <npiggin@kernel.dk>,
Peter Zijlstra <peterz@infradead.org>
Subject: [PATCH 3/3] access_error API cleanup
Date: Tue, 5 Oct 2010 00:53:35 -0700 [thread overview]
Message-ID: <1286265215-9025-4-git-send-email-walken@google.com> (raw)
In-Reply-To: <1286265215-9025-1-git-send-email-walken@google.com>
access_error() already takes error_code as an argument, so there is
no need for an additional write flag.
Signed-off-by: Michel Lespinasse <walken@google.com>
---
arch/x86/mm/fault.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c
index b355b92..844d46f 100644
--- a/arch/x86/mm/fault.c
+++ b/arch/x86/mm/fault.c
@@ -915,9 +915,9 @@ spurious_fault(unsigned long error_code, unsigned long address)
int show_unhandled_signals = 1;
static inline int
-access_error(unsigned long error_code, int write, struct vm_area_struct *vma)
+access_error(unsigned long error_code, struct vm_area_struct *vma)
{
- if (write) {
+ if (error_code & PF_WRITE) {
/* write, present and write, not present: */
if (unlikely(!(vma->vm_flags & VM_WRITE)))
return 1;
@@ -1110,7 +1110,7 @@ retry:
* we can handle it..
*/
good_area:
- if (unlikely(access_error(error_code, write, vma))) {
+ if (unlikely(access_error(error_code, vma))) {
bad_area_access_error(regs, error_code, address);
return;
}
--
1.7.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-10-05 7:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-05 7:53 [PATCH 0/3] V2: Reduce mmap_sem hold times during file backed page faults Michel Lespinasse
2010-10-05 7:53 ` [PATCH 1/3] filemap_fault: unique path for locking page Michel Lespinasse
2010-10-05 17:07 ` Rik van Riel
2010-10-05 7:53 ` [PATCH 2/3] Retry page fault when blocking on disk transfer Michel Lespinasse
2010-10-05 17:33 ` Linus Torvalds
2010-10-05 17:38 ` Rik van Riel
2010-10-05 22:44 ` Michel Lespinasse
2010-10-08 4:39 ` Michel Lespinasse
2010-10-08 13:24 ` Rik van Riel
2010-10-08 20:06 ` Michel Lespinasse
2010-10-09 1:22 ` Michel Lespinasse
2010-10-11 22:25 ` Andrew Morton
2010-10-11 22:43 ` Michel Lespinasse
2010-10-13 23:17 ` Andrew Morton
2010-10-06 4:02 ` H. Peter Anvin
2010-10-05 7:53 ` Michel Lespinasse [this message]
2010-10-05 19:44 ` [PATCH 3/3] access_error API cleanup Rik van Riel
2010-10-06 4:02 ` H. Peter Anvin
2010-10-06 4:14 ` Michel Lespinasse
2010-10-06 4:18 ` Andrew Morton
2010-10-06 4:20 ` H. Peter Anvin
2010-10-05 14:55 ` [PATCH 0/3] V2: Reduce mmap_sem hold times during file backed page faults Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286265215-9025-4-git-send-email-walken@google.com \
--to=walken@google.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@kernel.dk \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).