From: Bob Liu <lliubbo@gmail.com>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, fengguang.wu@intel.com,
kamezawa.hiroyu@jp.fujitsu.com, mel@csn.ul.ie,
kosaki.motohiro@jp.fujitsu.com, Bob Liu <lliubbo@gmail.com>
Subject: [PATCH 3/3] do_migrate_range: reduce list_empty() check.
Date: Thu, 21 Oct 2010 21:28:21 +0800 [thread overview]
Message-ID: <1287667701-8081-3-git-send-email-lliubbo@gmail.com> (raw)
In-Reply-To: <1287667701-8081-2-git-send-email-lliubbo@gmail.com>
simple code for reducing list_empty(&source) check.
Signed-off-by: Bob Liu <lliubbo@gmail.com>
---
mm/memory_hotplug.c | 17 +++++++----------
1 files changed, 7 insertions(+), 10 deletions(-)
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 4f72184..b6ffcfe 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -718,22 +718,19 @@ do_migrate_range(unsigned long start_pfn, unsigned long end_pfn)
check this again here. */
if (page_count(page)) {
not_managed++;
+ ret = -EBUSY;
break;
}
}
}
- ret = -EBUSY;
- if (not_managed) {
- if (!list_empty(&source))
+ if (!list_empty(&source)) {
+ if (not_managed) {
putback_lru_pages(&source);
- goto out;
+ goto out;
+ }
+ /* this function returns # of failed pages */
+ ret = migrate_pages(&source, hotremove_migrate_alloc, 0, 1);
}
- ret = 0;
- if (list_empty(&source))
- goto out;
- /* this function returns # of failed pages */
- ret = migrate_pages(&source, hotremove_migrate_alloc, 0, 1);
-
out:
return ret;
}
--
1.5.6.3
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-10-21 13:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 13:28 [PATCH 1/3] page_isolation: codeclean fix comment and rm unneeded val init Bob Liu
2010-10-21 13:28 ` [PATCH 2/3] do_migrate_range: exit loop if not_managed is true Bob Liu
2010-10-21 13:28 ` Bob Liu [this message]
2010-10-22 3:17 ` [PATCH 3/3] do_migrate_range: reduce list_empty() check KAMEZAWA Hiroyuki
2010-10-25 6:02 ` Wu Fengguang
2010-10-25 21:36 ` Andrew Morton
2010-10-21 14:25 ` [PATCH 2/3] do_migrate_range: exit loop if not_managed is true Wu Fengguang
2010-10-22 2:48 ` Bob Liu
2010-10-22 3:22 ` Wu Fengguang
2010-10-22 8:41 ` Bob Liu
2010-10-22 10:23 ` Wu Fengguang
2010-10-22 3:16 ` KAMEZAWA Hiroyuki
2010-10-22 8:41 ` Bob Liu
2010-10-22 8:43 ` KAMEZAWA Hiroyuki
2010-10-25 5:51 ` Wu Fengguang
2010-10-21 14:01 ` [PATCH 1/3] page_isolation: codeclean fix comment and rm unneeded val init Wu Fengguang
2010-10-22 2:34 ` Bob Liu
2010-10-22 3:13 ` Wu Fengguang
2010-10-22 3:12 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287667701-8081-3-git-send-email-lliubbo@gmail.com \
--to=lliubbo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).