From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: John David Anglin <dave@hiauly1.hia.nrc.ca>
Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org,
linux-parisc@vger.kernel.org, peterz@infradead.org
Subject: Re: [PATCH] parisc: fix compile failure with kmap_atomic changes
Date: Thu, 28 Oct 2010 12:39:40 -0500 [thread overview]
Message-ID: <1288287580.3043.159.camel@mulgrave.site> (raw)
In-Reply-To: <20101028171302.5D8944CFC@hiauly1.hia.nrc.ca>
On Thu, 2010-10-28 at 13:13 -0400, John David Anglin wrote:
> > On Thu, 2010-10-28 at 01:18 -0400, John David Anglin wrote:
> > > Signed-off-by: John David Anglin <dave.anglin@nrc-cnrc.gc.ca>
> > >
> > > Sent effectively the same change to parisc-linux list months ago...
> >
> > You did? Why didn't you send it to Peter? When I grumbled at him on
> > IRC for breaking parisc (as well as quite a few other 64 bit
> > architectures in mainline) he had no idea there was a problem.
>
> For example, it is in the diff recently posted here:
> http://permalink.gmane.org/gmane.linux.ports.parisc/3173
> This diff is from last May.
Um, so that doesn't fix the compile failure.
The specific problem is that kmap_atomic no longer takes the index
argument because Peter moved it to a stack based implementation. All
our kmap_atomic primitives in asm/cacheflush.h still have the extra
index argument which causes a compile failure.
To fix it, I had to run through a bunch of renames and extra argument
removals.
James
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-10-28 17:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 18:35 [PATCH] parisc: fix compile failure with kmap_atomic changes James Bottomley
2010-10-28 5:18 ` John David Anglin
2010-10-28 14:03 ` James Bottomley
2010-10-28 17:13 ` John David Anglin
2010-10-28 17:39 ` James Bottomley [this message]
2010-10-28 18:11 ` John David Anglin
2010-10-28 14:16 ` Kyle McMartin
2010-10-28 14:26 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288287580.3043.159.camel@mulgrave.site \
--to=james.bottomley@hansenpartnership.com \
--cc=dave@hiauly1.hia.nrc.ca \
--cc=linux-arch@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-parisc@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).