From: Greg Thelen <gthelen@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Balbir Singh <balbir@linux.vnet.ibm.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
Johannes Weiner <hannes@cmpxchg.org>,
Wu Fengguang <fengguang.wu@intel.com>,
Minchan Kim <minchan.kim@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Greg Thelen <gthelen@google.com>
Subject: [PATCH 5/6] memcg: simplify mem_cgroup_dirty_info()
Date: Tue, 9 Nov 2010 01:24:30 -0800 [thread overview]
Message-ID: <1289294671-6865-6-git-send-email-gthelen@google.com> (raw)
In-Reply-To: <1289294671-6865-1-git-send-email-gthelen@google.com>
Because mem_cgroup_page_stat() no longer returns negative numbers
to indicate failure, mem_cgroup_dirty_info() does not need to check
for such failures.
Signed-off-by: Greg Thelen <gthelen@google.com>
---
mm/memcontrol.c | 14 +++-----------
1 files changed, 3 insertions(+), 11 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index f8df350..ccdbb7e 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -1258,8 +1258,6 @@ bool mem_cgroup_dirty_info(unsigned long sys_available_mem,
__mem_cgroup_dirty_param(&dirty_param, memcg);
value = mem_cgroup_page_stat(memcg, MEMCG_NR_DIRTYABLE_PAGES);
- if (value < 0)
- goto done;
available_mem = min((unsigned long)value, sys_available_mem);
@@ -1279,15 +1277,9 @@ bool mem_cgroup_dirty_info(unsigned long sys_available_mem,
(dirty_param.dirty_background_ratio *
available_mem) / 100;
- value = mem_cgroup_page_stat(memcg, MEMCG_NR_RECLAIM_PAGES);
- if (value < 0)
- goto done;
- info->nr_reclaimable = value;
-
- value = mem_cgroup_page_stat(memcg, MEMCG_NR_WRITEBACK);
- if (value < 0)
- goto done;
- info->nr_writeback = value;
+ info->nr_reclaimable =
+ mem_cgroup_page_stat(memcg, MEMCG_NR_RECLAIM_PAGES);
+ info->nr_writeback = mem_cgroup_page_stat(memcg, MEMCG_NR_WRITEBACK);
valid = true;
--
1.7.3.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-11-09 9:25 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 9:24 [PATCH 0/6] *** memcg: make throttle_vm_writeout() cgroup aware *** Greg Thelen
2010-11-09 9:24 ` [PATCH 1/6] memcg: add mem_cgroup parameter to mem_cgroup_page_stat() Greg Thelen
2010-11-09 22:53 ` Minchan Kim
2010-11-10 0:51 ` Minchan Kim
2010-11-16 3:50 ` KAMEZAWA Hiroyuki
2010-11-22 6:40 ` Balbir Singh
2010-11-09 9:24 ` [PATCH 2/6] memcg: pass mem_cgroup to mem_cgroup_dirty_info() Greg Thelen
2010-11-09 23:09 ` Minchan Kim
2010-11-16 3:51 ` KAMEZAWA Hiroyuki
2010-11-22 6:41 ` Balbir Singh
2010-11-09 9:24 ` [PATCH 3/6] memcg: make throttle_vm_writeout() memcg aware Greg Thelen
2010-11-09 23:22 ` Minchan Kim
2010-11-12 8:17 ` Johannes Weiner
2010-11-12 20:39 ` Greg Thelen
2010-11-16 3:57 ` KAMEZAWA Hiroyuki
2010-11-19 11:16 ` Johannes Weiner
2010-11-09 9:24 ` [PATCH 4/6] memcg: simplify mem_cgroup_page_stat() Greg Thelen
2010-11-09 23:36 ` Minchan Kim
2010-11-12 8:19 ` Johannes Weiner
2010-11-12 20:40 ` Greg Thelen
2010-11-19 11:22 ` Johannes Weiner
2010-11-16 3:58 ` KAMEZAWA Hiroyuki
2010-11-09 9:24 ` Greg Thelen [this message]
2010-11-10 1:01 ` [PATCH 5/6] memcg: simplify mem_cgroup_dirty_info() Minchan Kim
2010-11-12 8:21 ` Johannes Weiner
2010-11-12 20:40 ` Greg Thelen
2010-11-09 9:24 ` [PATCH 6/6] memcg: make mem_cgroup_page_stat() return value unsigned Greg Thelen
2010-11-09 12:15 ` Wu Fengguang
2010-11-10 1:04 ` Minchan Kim
2010-11-12 8:29 ` Johannes Weiner
2010-11-12 20:41 ` Greg Thelen
2010-11-19 11:39 ` Johannes Weiner
2010-11-16 4:00 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289294671-6865-6-git-send-email-gthelen@google.com \
--to=gthelen@google.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=fengguang.wu@intel.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).