From: Mel Gorman <mel@csn.ul.ie>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>, Mel Gorman <mel@csn.ul.ie>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH 6/8] mm: compaction: Perform a faster scan in try_to_compact_pages()
Date: Wed, 17 Nov 2010 16:22:47 +0000 [thread overview]
Message-ID: <1290010969-26721-7-git-send-email-mel@csn.ul.ie> (raw)
In-Reply-To: <1290010969-26721-1-git-send-email-mel@csn.ul.ie>
try_to_compact_pages() is the faster compaction option available to the
allocator. It is optimistically called before direct reclaim is entered.
As there is a higher chance try_to_compact_pages() will fail than direct
reclaim, it's important to complete the work as quickly as possible to
minimise stalls.
This patch introduces a migrate_fast_scan to memory compaction. When set
by try_to_compact_pages(), only MIGRATE_MOVABLE pageblocks are considered
as migration candidates and migration is asynchronous. This reduces stalls
when allocating huge pages while not impairing allocation success rates as
the direct reclaim path will perform the full compaction.
Signed-off-by: Mel Gorman <mel@csn.ul.ie>
---
mm/compaction.c | 23 +++++++++++++++++++----
1 files changed, 19 insertions(+), 4 deletions(-)
diff --git a/mm/compaction.c b/mm/compaction.c
index 75d46d8..686db84 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -33,7 +33,10 @@ struct compact_control {
unsigned long nr_migratepages; /* Number of pages to migrate */
unsigned long free_pfn; /* isolate_freepages search base */
unsigned long migrate_pfn; /* isolate_migratepages search base */
- bool sync; /* Synchronous migration */
+ bool migrate_fast_scan; /* If true, only MIGRATE_MOVABLE blocks
+ * are scanned for pages to migrate and
+ * migration is asynchronous
+ */
/* Account for isolated anon and file pages */
unsigned long nr_anon;
@@ -240,6 +243,7 @@ static unsigned long isolate_migratepages(struct zone *zone,
struct compact_control *cc)
{
unsigned long low_pfn, end_pfn;
+ unsigned long last_pageblock_nr = 0, pageblock_nr;
unsigned long nr_scanned = 0, nr_isolated = 0;
struct list_head *migratelist = &cc->migratepages;
@@ -280,6 +284,17 @@ static unsigned long isolate_migratepages(struct zone *zone,
if (PageBuddy(page))
continue;
+ /* When fast scanning, only scan in MOVABLE blocks */
+ pageblock_nr = low_pfn >> pageblock_order;
+ if (cc->migrate_fast_scan &&
+ last_pageblock_nr != pageblock_nr &&
+ get_pageblock_migratetype(page) != MIGRATE_MOVABLE) {
+ low_pfn += pageblock_nr_pages;
+ low_pfn = ALIGN(low_pfn, pageblock_nr_pages) - 1;
+ last_pageblock_nr = pageblock_nr;
+ continue;
+ }
+
/* Try isolate the page */
if (__isolate_lru_page(page, ISOLATE_BOTH, 0) != 0)
continue;
@@ -451,7 +466,7 @@ static int compact_zone(struct zone *zone, struct compact_control *cc)
nr_migrate = cc->nr_migratepages;
migrate_pages(&cc->migratepages, compaction_alloc,
(unsigned long)cc, false,
- cc->sync);
+ cc->migrate_fast_scan ? false : true);
update_nr_listpages(cc);
nr_remaining = cc->nr_migratepages;
@@ -485,8 +500,8 @@ static unsigned long compact_zone_order(struct zone *zone,
.nr_migratepages = 0,
.order = order,
.migratetype = allocflags_to_migratetype(gfp_mask),
+ .migrate_fast_scan = true,
.zone = zone,
- .sync = false,
};
INIT_LIST_HEAD(&cc.freepages);
INIT_LIST_HEAD(&cc.migratepages);
@@ -502,8 +517,8 @@ unsigned long reclaimcompact_zone_order(struct zone *zone,
.nr_migratepages = 0,
.order = order,
.migratetype = allocflags_to_migratetype(gfp_mask),
+ .migrate_fast_scan = false,
.zone = zone,
- .sync = true,
};
INIT_LIST_HEAD(&cc.freepages);
INIT_LIST_HEAD(&cc.migratepages);
--
1.7.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-11-17 16:22 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 16:22 [PATCH 0/8] Use memory compaction instead of lumpy reclaim during high-order allocations Mel Gorman
2010-11-17 16:22 ` [PATCH 1/8] mm: compaction: Add trace events for memory compaction activity Mel Gorman
2010-11-17 16:22 ` [PATCH 2/8] mm: vmscan: Convert lumpy_mode into a bitmask Mel Gorman
2010-11-17 16:22 ` [PATCH 3/8] mm: vmscan: Reclaim order-0 and use compaction instead of lumpy reclaim Mel Gorman
2010-11-18 18:09 ` Andrea Arcangeli
2010-11-18 18:30 ` Mel Gorman
2010-11-17 16:22 ` [PATCH 4/8] mm: migration: Allow migration to operate asynchronously and avoid synchronous compaction in the faster path Mel Gorman
2010-11-18 18:21 ` Andrea Arcangeli
2010-11-18 18:34 ` Mel Gorman
2010-11-18 19:00 ` Andrea Arcangeli
2010-11-17 16:22 ` [PATCH 5/8] mm: migration: Cleanup migrate_pages API by matching types for offlining and sync Mel Gorman
2010-11-17 16:22 ` Mel Gorman [this message]
2010-11-18 18:34 ` [PATCH 6/8] mm: compaction: Perform a faster scan in try_to_compact_pages() Andrea Arcangeli
2010-11-18 18:50 ` Mel Gorman
2010-11-18 19:08 ` Andrea Arcangeli
2010-11-19 11:16 ` Mel Gorman
2010-11-17 16:22 ` [PATCH 7/8] mm: compaction: Use the LRU to get a hint on where compaction should start Mel Gorman
2010-11-18 9:10 ` KAMEZAWA Hiroyuki
2010-11-18 9:28 ` Mel Gorman
2010-11-18 18:46 ` Andrea Arcangeli
2010-11-19 11:08 ` Mel Gorman
2010-11-17 16:22 ` [PATCH 8/8] mm: vmscan: Rename lumpy_mode to reclaim_mode Mel Gorman
2010-11-17 23:46 ` [PATCH 0/8] Use memory compaction instead of lumpy reclaim during high-order allocations Andrew Morton
2010-11-18 2:03 ` Rik van Riel
2010-11-18 8:12 ` Mel Gorman
2010-11-18 8:26 ` KAMEZAWA Hiroyuki
2010-11-18 8:38 ` Johannes Weiner
2010-11-18 9:20 ` Mel Gorman
2010-11-18 19:49 ` Andrew Morton
2010-11-19 10:48 ` Mel Gorman
2010-11-19 12:43 ` Theodore Tso
2010-11-19 14:05 ` Mel Gorman
2010-11-19 15:45 ` Ted Ts'o
2010-11-18 8:44 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290010969-26721-7-git-send-email-mel@csn.ul.ie \
--to=mel@csn.ul.ie \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).