linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Ben Gamari <bgamari.foss@gmail.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Minchan Kim <minchan.kim@gmail.com>,
	rsync@lists.samba.org
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Rik van Riel <riel@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Nick Piggin <npiggin@kernel.dk>,
	Ben Gamari <bgamari.foss@gmail.com>
Subject: [PATCH 3/3] Inform kernel of FADV_DONTNEED hint in receiver
Date: Tue, 23 Nov 2010 09:49:52 -0500	[thread overview]
Message-ID: <1290523792-6170-4-git-send-email-bgamari.foss@gmail.com> (raw)
In-Reply-To: <20101122103756.E236.A69D9226@jp.fujitsu.com>

Use the FADV_DONTNEED fadvise hint after finishing writing to a
destinataion fd in the receiver.
---
 receiver.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/receiver.c b/receiver.c
index 39c5e49..33b21fb 100644
--- a/receiver.c
+++ b/receiver.c
@@ -721,6 +721,12 @@ int recv_files(int f_in, char *local_name)
 		recv_ok = receive_data(f_in, fnamecmp, fd1, st.st_size,
 				       fname, fd2, F_LENGTH(file));
 
+                if (do_fadvise(fd2, 0, 0, POSIX_FADV_DONTNEED) != 0) {
+                        rsyserr(FERROR_XFER, errno,
+                                "fadvise failed in writing %s",
+                                full_fname(fname));
+                }
+
 		log_item(log_code, file, &initial_stats, iflags, NULL);
 
 		if (fd1 != -1)
-- 
1.7.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2010-11-23 14:50 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-21 14:30 [RFC 1/2] deactive invalidated pages Minchan Kim
2010-11-21 14:30 ` [RFC 2/2] Prevent promotion of page in madvise_dontneed Minchan Kim
2010-11-21 14:38   ` Minchan Kim
2010-11-21 16:34   ` Ben Gamari
2010-11-22  0:31     ` Minchan Kim
2010-11-22 22:21   ` Andrew Morton
2010-11-23  4:57     ` Minchan Kim
2010-11-23  9:50     ` Mel Gorman
2010-11-23 23:49       ` Minchan Kim
2010-11-21 15:21 ` [RFC 1/2] deactive invalidated pages Ben Gamari
2010-11-23  7:16   ` KOSAKI Motohiro
2010-11-23 13:48     ` Ben Gamari
2010-11-23 23:48       ` Minchan Kim
2010-11-23 14:49     ` [RFC PATCH] fadvise support in rsync Ben Gamari
2010-11-23 15:35       ` Pádraig Brady
2010-11-24  0:17       ` KOSAKI Motohiro
2010-11-23 14:49     ` [PATCH 1/3] Add fadvise interface wrapper Ben Gamari
2010-11-23 14:49     ` [PATCH 2/3] Inform kernel of FADV_DONTNEED hint in sender Ben Gamari
2010-11-23 14:49     ` Ben Gamari [this message]
2010-11-22  1:17 ` [RFC 1/2] deactive invalidated pages Rik van Riel
2010-11-22 22:14 ` Andrew Morton
2010-11-23  4:52   ` Minchan Kim
2010-11-23  5:01     ` Andrew Morton
2010-11-23  5:23       ` Minchan Kim
2010-11-23  5:22         ` Andrew Morton
2010-11-23  5:45           ` Minchan Kim
2010-11-23  5:48             ` Andrew Morton
2010-11-23  6:05               ` Minchan Kim
2010-11-23  7:15                 ` Andrew Morton
2010-11-23  7:44                   ` Minchan Kim
2010-11-23  7:53                     ` Andrew Morton
2010-11-23  8:02                       ` Minchan Kim
2010-11-23  9:43               ` Mel Gorman
2010-11-23 23:32                 ` Minchan Kim
2010-11-23  9:38       ` Mel Gorman
2010-11-23 14:55         ` Ben Gamari
2010-11-23 14:58           ` Mel Gorman
2010-11-23 20:35             ` Andrew Morton
2010-11-23 22:10               ` Mel Gorman
2010-11-23 23:45                 ` Minchan Kim
2010-11-24 18:01                   ` Mel Gorman
2010-11-23  7:16 ` KOSAKI Motohiro
2010-11-23  7:40   ` Minchan Kim
2010-11-23  7:42     ` Andrew Morton
2010-11-23  8:01     ` KOSAKI Motohiro
2010-11-23  8:44       ` Minchan Kim
2010-11-23  9:02         ` KOSAKI Motohiro
2010-11-23  9:05           ` Minchan Kim
2010-11-23  9:07             ` Minchan Kim
2010-11-23 14:57   ` Ben Gamari
2010-11-24  0:13     ` KOSAKI Motohiro
2010-11-23  9:28 ` Mel Gorman
2010-11-23 23:24   ` Minchan Kim
2010-11-24 10:02     ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1290523792-6170-4-git-send-email-bgamari.foss@gmail.com \
    --to=bgamari.foss@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan.kim@gmail.com \
    --cc=npiggin@kernel.dk \
    --cc=riel@redhat.com \
    --cc=rsync@lists.samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).