From: Peter Zijlstra <peterz@infradead.org>
To: Hugh Dickins <hughd@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Miklos Szeredi <miklos@szeredi.hu>,
Michael Leun <lkml20101129@newton.leun.net>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: kernel BUG at mm/truncate.c:475!
Date: Tue, 14 Dec 2010 10:10:07 +0100 [thread overview]
Message-ID: <1292317807.6803.1324.camel@twins> (raw)
In-Reply-To: <alpine.LSU.2.00.1012132246580.6071@sister.anvils>
On Mon, 2010-12-13 at 23:31 -0800, Hugh Dickins wrote:
> > then I suspect all the vm_truncate_count/restart_addr stuff can go away?
>
> That would be lovely, but in fact no: it's guarding against operations on
> vmas, things like munmap and mprotect, which can shuffle the prio_tree
> when i_mmap_lock is dropped, without i_mutex ever being taken.
>
> However, if we adopt Peter's preemptible mmu_gather patches, i_mmap_lock
> becomes a mutex, so there's then no need for any of this (I think Peter
> just did a straight conversion here, leaving it in, but it becomes
> pointless and would gladly be removed).
I'm still trying to sell that series, so if you see any value in it,
please reply with positive feedback ;-)
Also, the whole vm_truncate_count/restart_addr isn't entirely useless,
its still a lock break which might help with long held locks. Imagine
someone trying to unmap several TB worth of pages at once (not entirely
beyond the realm of possibility today, and we all know tomorrow will be
huge).
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-12-14 9:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20101130194945.58962c44@xenia.leun.net>
2010-11-30 23:00 ` kernel BUG at mm/truncate.c:475! Hugh Dickins
2010-12-01 10:25 ` Miklos Szeredi
2010-12-01 11:45 ` Michael Leun
2010-12-01 17:22 ` Miklos Szeredi
2010-12-02 7:41 ` Michael Leun
2010-12-02 8:15 ` Michael Leun
2010-12-02 9:42 ` Miklos Szeredi
2010-12-02 10:57 ` Michael Leun
2010-12-03 7:53 ` Michael Leun
2010-12-06 12:36 ` Miklos Szeredi
2010-12-06 19:43 ` Michael Leun
2010-12-11 14:14 ` Miklos Szeredi
2010-12-11 19:50 ` Michael Leun
2010-12-13 22:20 ` Andrew Morton
2010-12-14 7:31 ` Hugh Dickins
2010-12-14 9:10 ` Peter Zijlstra [this message]
2010-12-14 9:11 ` Peter Zijlstra
2010-12-14 10:45 ` Miklos Szeredi
2010-12-15 4:32 ` Hugh Dickins
2010-12-15 11:22 ` Miklos Szeredi
2010-12-16 0:26 ` Hugh Dickins
2010-12-16 14:50 ` Robert Święcki
2010-12-16 19:05 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292317807.6803.1324.camel@twins \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkml20101129@newton.leun.net \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).