From: Namhyung Kim <namhyung@gmail.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH] memblock: Fix error path in memblock_add_region()
Date: Mon, 07 Feb 2011 14:00:27 +0900 [thread overview]
Message-ID: <1297054827.1444.2.camel@leonhard> (raw)
In-Reply-To: <4D4EDE69.9060200@kernel.org>
2011-02-06 (i? 1/4 ), 09:46 -0800, Yinghai Lu:
> we can skip the restoring.
>
> Thanks
>
> Yinghai
>
> diff --git a/mm/memblock.c b/mm/memblock.c
> index bdba245..3231657 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -374,13 +374,9 @@ static long __init_memblock memblock_add_region(struct memblock_type *type, phys
> }
> type->cnt++;
>
> - /* The array is full ? Try to resize it. If that fails, we undo
> - * our allocation and return an error
> - */
> - if (type->cnt == type->max && memblock_double_array(type)) {
> - type->cnt--;
> + /* The array is full ? Try to resize it */
> + if (type->cnt == type->max && memblock_double_array(type))
> return -1;
> - }
>
> return 0;
> }
Looks OK to me, too.
Thanks.
--
Regards,
Namhyung Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-02-07 5:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-06 13:31 [PATCH] memblock: Fix error path in memblock_add_region() Namhyung Kim
2011-02-06 17:46 ` Yinghai Lu
2011-02-07 5:00 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297054827.1444.2.camel@leonhard \
--to=namhyung@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).