From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Andi Kleen <ak@linux.intel.com>,
aarcange@redhat.com
Subject: Re: [PATCH 8/8] Add VM counters for transparent hugepages
Date: Thu, 24 Feb 2011 14:43:04 -0800 [thread overview]
Message-ID: <1298587384.9138.23.camel@nimitz> (raw)
In-Reply-To: <1298425922-23630-9-git-send-email-andi@firstfloor.org>
On Tue, 2011-02-22 at 17:52 -0800, Andi Kleen wrote:
> @@ -2286,6 +2290,9 @@ void __split_huge_page_pmd(struct mm_struct *mm, pmd_t *pmd)
> spin_unlock(&mm->page_table_lock);
> return;
> }
> +
> + count_vm_event(THP_SPLIT);
> +
> page = pmd_page(*pmd);
> VM_BUG_ON(!page_count(page));
> get_page(page);
Hey Andi,
Your split counter tracks the split_huge_page_pmd() calls, but misses
plain split_huge_page() calls. Did you do this on purpose? Could we
move the counter in to the low-level split function like below?
---
linux-2.6.git-dave/mm/huge_memory.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -puN mm/huge_memory.c~move-THP_SPLIT mm/huge_memory.c
--- linux-2.6.git/mm/huge_memory.c~move-THP_SPLIT 2011-02-24 14:37:32.825288409 -0800
+++ linux-2.6.git-dave/mm/huge_memory.c 2011-02-24 14:39:01.767939971 -0800
@@ -1342,6 +1342,8 @@ static void __split_huge_page(struct pag
BUG_ON(!PageHead(page));
BUG_ON(PageTail(page));
+ count_vm_event(THP_SPLIT);
+
mapcount = 0;
list_for_each_entry(avc, &anon_vma->head, same_anon_vma) {
struct vm_area_struct *vma = avc->vma;
@@ -2293,8 +2295,6 @@ void __split_huge_page_pmd(struct mm_str
return;
}
- count_vm_event(THP_SPLIT);
-
page = pmd_page(*pmd);
VM_BUG_ON(!page_count(page));
get_page(page);
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-02-24 22:43 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 1:51 Fix NUMA problems in transparent hugepages v2 Andi Kleen
2011-02-23 1:51 ` [PATCH 1/8] Fix interleaving for " Andi Kleen
2011-02-23 19:26 ` Christoph Lameter
2011-02-24 23:23 ` Andrea Arcangeli
2011-02-23 1:51 ` [PATCH 2/8] Change alloc_pages_vma to pass down the policy node for local policy Andi Kleen
2011-02-23 1:51 ` [PATCH 3/8] Add alloc_page_vma_node Andi Kleen
2011-02-23 1:51 ` [PATCH 4/8] Preserve original node for transparent huge page copies Andi Kleen
2011-02-23 1:51 ` [PATCH 5/8] Use correct numa policy node for transparent hugepages Andi Kleen
2011-02-23 1:52 ` [PATCH 6/8] Add __GFP_OTHER_NODE flag Andi Kleen
2011-02-23 1:52 ` [PATCH 7/8] Use GFP_OTHER_NODE for transparent huge pages Andi Kleen
2011-02-24 4:56 ` Andrea Arcangeli
2011-02-23 1:52 ` [PATCH 8/8] Add VM counters for transparent hugepages Andi Kleen
2011-02-24 4:18 ` Andrea Arcangeli
2011-02-24 22:43 ` Dave Hansen
2011-02-24 23:15 ` Andrea Arcangeli
2011-02-24 22:43 ` Dave Hansen [this message]
2011-02-24 23:14 ` Andrea Arcangeli
2011-02-25 1:36 ` Andi Kleen
2011-02-25 0:51 ` Andrea Arcangeli
2011-02-25 1:12 ` Andi Kleen
2011-02-25 1:34 ` Andrea Arcangeli
-- strict thread matches above, loose matches on Subject: below --
2011-03-03 19:59 Fix NUMA problems in transparent hugepages and KSM Andi Kleen
2011-03-03 19:59 ` [PATCH 8/8] Add VM counters for transparent hugepages Andi Kleen
2011-03-07 8:28 ` KOSAKI Motohiro
2011-03-07 16:35 ` Andi Kleen
2011-03-08 2:43 ` KOSAKI Motohiro
2011-03-30 21:45 ` Andrew Morton
2011-03-30 23:30 ` Andi Kleen
2011-03-31 0:52 ` KOSAKI Motohiro
2011-03-31 0:56 ` Andi Kleen
2011-03-03 0:45 Fix NUMA problems in transparent hugepages and KSM Andi Kleen
2011-03-03 0:45 ` [PATCH 8/8] Add VM counters for transparent hugepages Andi Kleen
2011-03-03 9:18 ` Johannes Weiner
2011-03-03 18:09 ` Andi Kleen
2011-02-21 19:07 Fix NUMA problems in transparent hugepages and KSM Andi Kleen
2011-02-21 19:07 ` [PATCH 8/8] Add VM counters for transparent hugepages Andi Kleen
2011-02-22 16:36 ` Dave Hansen
2011-02-22 16:43 ` Andrea Arcangeli
2011-02-22 18:02 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298587384.9138.23.camel@nimitz \
--to=dave@linux.vnet.ibm.com \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).