linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrey Vagin <avagin@openvz.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Mel Gorman <mel@csn.ul.ie>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	avagin@openvz.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] mm: check zone->all_unreclaimable in all_unreclaimable()
Date: Sat,  5 Mar 2011 14:44:16 +0300	[thread overview]
Message-ID: <1299325456-2687-1-git-send-email-avagin@openvz.org> (raw)

Check zone->all_unreclaimable in all_unreclaimable(), otherwise the
kernel may hang up, because shrink_zones() will do nothing, but
all_unreclaimable() will say, that zone has reclaimable pages.

do_try_to_free_pages()
	shrink_zones()
		 for_each_zone
			if (zone->all_unreclaimable)
				continue
	if !all_unreclaimable(zonelist, sc)
		return 1

__alloc_pages_slowpath()
retry:
	did_some_progress = do_try_to_free_pages(page)
	...
	if (!page && did_some_progress)
		retry;

Signed-off-by: Andrey Vagin <avagin@openvz.org>
---
 mm/vmscan.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index 6771ea7..1c056f7 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -2002,6 +2002,8 @@ static bool all_unreclaimable(struct zonelist *zonelist,
 
 	for_each_zone_zonelist_nodemask(zone, z, zonelist,
 			gfp_zone(sc->gfp_mask), sc->nodemask) {
+		if (zone->all_unreclaimable)
+			continue;
 		if (!populated_zone(zone))
 			continue;
 		if (!cpuset_zone_allowed_hardwall(zone, GFP_KERNEL))
-- 
1.7.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2011-03-05 11:44 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-05 11:44 Andrey Vagin [this message]
2011-03-05 15:20 ` [PATCH] mm: check zone->all_unreclaimable in all_unreclaimable() Minchan Kim
2011-03-05 15:34   ` Andrew Vagin
2011-03-05 15:53     ` Minchan Kim
2011-03-05 16:41       ` Andrew Vagin
2011-03-05 17:07         ` Minchan Kim
2011-03-07 21:58           ` Andrew Morton
2011-03-07 23:45             ` Minchan Kim
2011-03-09  5:37               ` KAMEZAWA Hiroyuki
2011-03-09  5:43                 ` KAMEZAWA Hiroyuki
2011-03-10  6:58                 ` Minchan Kim
2011-03-10 23:58                   ` KAMEZAWA Hiroyuki
2011-03-11  0:18                     ` Minchan Kim
2011-03-11  6:08                       ` avagin
2011-03-14  1:03                         ` Minchan Kim
2011-03-08  0:44             ` KAMEZAWA Hiroyuki
2011-03-08  3:06               ` KOSAKI Motohiro
2011-03-08 19:02                 ` avagin
2011-03-09  5:52                   ` KAMEZAWA Hiroyuki
2011-03-09  6:17                   ` KOSAKI Motohiro
2011-03-10 14:08                     ` KOSAKI Motohiro
2011-03-08  8:12               ` Andrew Vagin
2011-03-09  6:06                 ` KAMEZAWA Hiroyuki
2011-05-04  1:38     ` CAI Qian
2011-05-09  6:54       ` KOSAKI Motohiro
2011-05-09  8:47         ` CAI Qian
2011-05-09  9:19           ` KOSAKI Motohiro
2011-05-10  8:11             ` OOM Killer don't works at all if the system have >gigabytes memory (was Re: [PATCH] mm: check zone->all_unreclaimable in all_unreclaimable()) KOSAKI Motohiro
2011-05-10  8:14               ` [PATCH 1/4] oom: improve dump_tasks() show items KOSAKI Motohiro
2011-05-10 23:29                 ` David Rientjes
2011-05-13 10:14                   ` KOSAKI Motohiro
2011-05-10  8:15               ` [PATCH 2/4] oom: kill younger process first KOSAKI Motohiro
2011-05-10 23:31                 ` David Rientjes
2011-05-13 10:15                   ` KOSAKI Motohiro
2011-05-11 23:33                 ` Minchan Kim
2011-05-12  0:52                 ` KAMEZAWA Hiroyuki
2011-05-12  1:30                   ` Minchan Kim
2011-05-12  1:53                     ` KAMEZAWA Hiroyuki
2011-05-12  2:23                       ` Minchan Kim
2011-05-12  3:39                         ` KAMEZAWA Hiroyuki
2011-05-12  4:17                           ` Minchan Kim
2011-05-12 14:38                             ` Paul E. McKenney
2011-05-13 10:18                   ` KOSAKI Motohiro
2011-05-10  8:15               ` [PATCH 3/4] oom: oom-killer don't use permillage of system-ram internally KOSAKI Motohiro
2011-05-10 23:40                 ` David Rientjes
2011-05-13 10:30                   ` KOSAKI Motohiro
2011-05-10  8:16               ` [PATCH 4/4] oom: don't kill random process KOSAKI Motohiro
2011-05-10 23:41                 ` David Rientjes
2011-05-10 23:22               ` OOM Killer don't works at all if the system have >gigabytes memory (was Re: [PATCH] mm: check zone->all_unreclaimable in all_unreclaimable()) David Rientjes
2011-05-11  2:30               ` CAI Qian
2011-05-11 20:34                 ` David Rientjes
2011-05-12  0:13                   ` Minchan Kim
2011-05-12 19:38                     ` David Rientjes
2011-05-13  4:16                       ` Minchan Kim
2011-05-13 11:04                         ` KOSAKI Motohiro
2011-05-16 20:42                           ` David Rientjes
2011-05-13  6:53                   ` CAI Qian
2011-05-16 20:46                     ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1299325456-2687-1-git-send-email-avagin@openvz.org \
    --to=avagin@openvz.org \
    --cc=akpm@linux-foundation.org \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).