From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13BBBC4332F for ; Fri, 2 Dec 2022 21:25:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5CC5F6B0071; Fri, 2 Dec 2022 16:25:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 57BD56B0072; Fri, 2 Dec 2022 16:25:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41C8E6B0073; Fri, 2 Dec 2022 16:25:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 302CA6B0071 for ; Fri, 2 Dec 2022 16:25:59 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id F1D2B14141D for ; Fri, 2 Dec 2022 21:25:58 +0000 (UTC) X-FDA: 80198648796.06.CE28597 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by imf28.hostedemail.com (Postfix) with ESMTP id 9AFCBC000D for ; Fri, 2 Dec 2022 21:25:58 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=iJkJGBrX; spf=pass (imf28.hostedemail.com: domain of alexander.duyck@gmail.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=alexander.duyck@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670016358; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jBNUTCSkkYzvGe+KqD5Q14RPIoFCYbk500Bx/00wZJY=; b=SfYH7vc3SC8KZNrZtvC4ey5cJv+B5hid6B1nOqADGZyvRoASbBvL3SXjPKdlNON58EPY/X ictr2TmyJ8kYGHBhXP7IojBJPV3kpeXggXWJXxoftgjswk9EIBaazdWEZt55IfV6d7Eu5E /RsNJFo0Hjq+uPK5vIxI87iFIj4T1qA= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=iJkJGBrX; spf=pass (imf28.hostedemail.com: domain of alexander.duyck@gmail.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=alexander.duyck@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670016358; a=rsa-sha256; cv=none; b=YWl7lSM2Ptov7lKzG3mD9mkzavQWxZ/79xciw6yXJjmOd6pN+BRkUJK0TcMm+4+1A5K+Ry Wb+4OFTS/s6CzD54DKQRIGptGaaaqD53G1KM197hHCOsXRm6a6cX5CBs0Iw+BT18DkN8Dz CYGocSBXIH00tOkjBBQaHBCILIgYr44= Received: by mail-pl1-f176.google.com with SMTP id y17so5777188plp.3 for ; Fri, 02 Dec 2022 13:25:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=jBNUTCSkkYzvGe+KqD5Q14RPIoFCYbk500Bx/00wZJY=; b=iJkJGBrXv95E5Xj4ETzcLdCsj029lB89lWExskYIeZxTv/LdsDj1DHERq3RiKoS6Ki zDTC4P4fKvv+a3iVLFyXPsVx0fvRJzUjL/6HXCWI2MQku4HyrRPfLNn7bfpLaRErH4UE RyMGboHjrjyVragQGGBsbS3u2Y59gS+AumNAP3mZxIU2MJ5RtWY+rJmGaGsl6zcpCCCs gRKsnaBhvoDqJbtAmGiZrtVFeG6LgczOo6/vtaePyjC2LOpvkoPeje6wqU3cy7Yvs1Ot DWU1PD1bH418oTp/kLsmeasUB6Omu3vXe+WFS3B9d2frbXlua/WI0AdGb4PRBJi0Xadf 7VLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=jBNUTCSkkYzvGe+KqD5Q14RPIoFCYbk500Bx/00wZJY=; b=HSH1bB4zckDjjqWDhHlhiCM+XlXJWsijXciEdXDsOkBDOGNJUPzavIj2wM9e6s5064 h+lJNvNQJpTBhyL5zlgLpGJkQmPUVYBjtcYGBjrnbFovIyaoBgmuTmibG6ZXfppDXWz2 046WvTNEyBozTafy3Zc2ucWk0UC5VdGZ+WUHCthHXavOXSj10hEPEnMF+gl+qu6pKRw5 RveWxWuVBNKkPf4m6szVKWaXyipwPT7Q7TnJp4GaqqSU6jQQP/eb5vsjkpH5vsxRdiDv w7S7l/HkFyBZHF1WF3VbhSdHbFDbXCV+Zch5JMIW8ha6yujujMzhlOde51nQ3vshYlod sxIQ== X-Gm-Message-State: ANoB5pndyOC1STtDr96qA+6tnwgSvvVHH2mgxlnx4qZabf60Geltus4P J4THkdxjkmdFG5/8INmgYfOlFT3InuM= X-Google-Smtp-Source: AA0mqf50lmP3jPdFlvHqEIhm8sTHJT/0joZz+V7FietxbIA4yTK/IO1Sg97saaEsaSMl25RVMWVsLg== X-Received: by 2002:a17:902:7585:b0:186:ee56:4a14 with SMTP id j5-20020a170902758500b00186ee564a14mr53714012pll.158.1670016357294; Fri, 02 Dec 2022 13:25:57 -0800 (PST) Received: from [192.168.0.128] ([98.97.42.38]) by smtp.googlemail.com with ESMTPSA id g18-20020a170902e39200b00188a908cbddsm5919765ple.302.2022.12.02.13.25.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Dec 2022 13:25:56 -0800 (PST) Message-ID: <12edd3e450e3dd596e3048609455bfc295e37dee.camel@gmail.com> Subject: Re: [PATCH 11/24] page_pool: Convert page_pool_empty_ring() to use netmem From: Alexander H Duyck To: "Matthew Wilcox (Oracle)" , Jesper Dangaard Brouer , Ilias Apalodimas Cc: netdev@vger.kernel.org, linux-mm@kvack.org Date: Fri, 02 Dec 2022 13:25:55 -0800 In-Reply-To: <20221130220803.3657490-12-willy@infradead.org> References: <20221130220803.3657490-1-willy@infradead.org> <20221130220803.3657490-12-willy@infradead.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9AFCBC000D X-Rspam-User: X-Stat-Signature: fi1peubdz91wos8u54narxbe3zqmj5uj X-Spamd-Result: default: False [-0.84 / 9.00]; BAYES_HAM(-4.94)[97.59%]; SORBS_IRL_BL(3.00)[209.85.214.176:from]; SUBJECT_HAS_UNDERSCORES(1.00)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; BAD_REP_POLICIES(0.10)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; MIME_TRACE(0.00)[0:+]; TAGGED_FROM(0.00)[]; DMARC_POLICY_ALLOW(0.00)[gmail.com,none]; RCPT_COUNT_FIVE(0.00)[5]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; R_DKIM_ALLOW(0.00)[gmail.com:s=20210112]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17:c]; TO_DN_SOME(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; ARC_NA(0.00)[] X-HE-Tag: 1670016358-101988 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 2022-11-30 at 22:07 +0000, Matthew Wilcox (Oracle) wrote: > Retrieve a netmem from the ptr_ring instead of a page. >=20 > Signed-off-by: Matthew Wilcox (Oracle) > --- > net/core/page_pool.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git a/net/core/page_pool.c b/net/core/page_pool.c > index e727a74504c2..7a77e3220205 100644 > --- a/net/core/page_pool.c > +++ b/net/core/page_pool.c > @@ -755,16 +755,16 @@ EXPORT_SYMBOL(page_pool_alloc_frag); > =20 > static void page_pool_empty_ring(struct page_pool *pool) > { > - struct page *page; > + struct netmem *nmem; > =20 > /* Empty recycle ring */ > - while ((page =3D ptr_ring_consume_bh(&pool->ring))) { > + while ((nmem =3D ptr_ring_consume_bh(&pool->ring)) !=3D NULL) { > /* Verify the refcnt invariant of cached pages */ > - if (!(page_ref_count(page) =3D=3D 1)) > + if (!(netmem_ref_count(nmem) =3D=3D 1)) One minor code nit here is that this could just be: if (netmem_ref_count(nmem) !=3D 1) > pr_crit("%s() page_pool refcnt %d violation\n", > - __func__, page_ref_count(page)); > + __func__, netmem_ref_count(nmem)); > =20 > - page_pool_return_page(pool, page); > + page_pool_return_netmem(pool, nmem); > } > } > =20