From: Matt Mackall <mpm@selenic.com>
To: George Spelvin <linux@horizon.com>
Cc: penberg@cs.helsinki.fi, herbert@gondor.apana.org.au,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/8] drivers/random: Cache align ip_random better
Date: Tue, 15 Mar 2011 21:54:14 -0500 [thread overview]
Message-ID: <1300244054.3128.417.camel@calx> (raw)
In-Reply-To: <20110316022804.27679.qmail@science.horizon.com>
On Sun, 2011-03-13 at 20:20 -0400, George Spelvin wrote:
> Cache aligning the secret[] buffer makes copying from it infinitesimally
> more efficient.
Acked-by: Matt Mackall <mpm@selenic.com>
> ---
> drivers/char/random.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/char/random.c b/drivers/char/random.c
> index 72a4fcb..4bcc4f2 100644
> --- a/drivers/char/random.c
> +++ b/drivers/char/random.c
> @@ -1417,8 +1417,8 @@ static __u32 twothirdsMD4Transform(__u32 const buf[4], __u32 const in[12])
> #define HASH_MASK ((1 << HASH_BITS) - 1)
>
> static struct keydata {
> - __u32 count; /* already shifted to the final position */
> __u32 secret[12];
> + __u32 count; /* already shifted to the final position */
> } ____cacheline_aligned ip_keydata[2];
>
> static unsigned int ip_cnt;
--
Mathematics is the supreme nostalgia of our time.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-03-16 2:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 0:20 [PATCH 1/8] drivers/random: Cache align ip_random better George Spelvin
2011-03-16 2:54 ` Matt Mackall [this message]
2011-03-16 6:24 ` Pekka Enberg
2011-03-16 17:17 ` Hugh Dickins
2011-03-16 18:10 ` George Spelvin
2011-03-16 18:42 ` Hugh Dickins
2011-03-16 19:45 ` George Spelvin
2011-03-22 9:03 ` Herbert Xu
2011-03-16 18:23 ` Matt Mackall
2011-03-16 19:26 ` Eric Dumazet
2011-03-16 19:55 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300244054.3128.417.camel@calx \
--to=mpm@selenic.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@horizon.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).