From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with SMTP id 6215C8D0039 for ; Wed, 16 Mar 2011 15:55:45 -0400 (EDT) Subject: Re: [PATCH 1/8] drivers/random: Cache align ip_random better From: Matt Mackall In-Reply-To: <1300303593.3202.30.camel@edumazet-laptop> References: <20110316022804.27679.qmail@science.horizon.com> <1300299787.3128.495.camel@calx> <1300303593.3202.30.camel@edumazet-laptop> Content-Type: text/plain; charset="UTF-8" Date: Wed, 16 Mar 2011 14:55:07 -0500 Message-ID: <1300305307.3128.528.camel@calx> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Eric Dumazet Cc: Hugh Dickins , George Spelvin , penberg@cs.helsinki.fi, herbert@gondor.hengli.com.au, linux-mm@kvack.org, linux-kernel@vger.kernel.org On Wed, 2011-03-16 at 20:26 +0100, Eric Dumazet wrote: > > I think this alignment exists to minimize the number of cacheline > > bounces on SMP as this can be a pretty hot structure in the network > > stack. It could probably benefit from a per-cpu treatment. > > > > Well, this is a mostly read area of memory, dirtied every 5 minutes. > > Compare this to 'jiffies' for example ;) > > What could be done is to embed 'ip_cnt' inside ip_keydata[0] for > example, to avoid wasting a cache line for one bit ;) > > > c1606c40 b ip_cnt > > c1606c80 b ip_keydata Yeah. I actually think we're due for rethinking this entire process. It dates back to when we introduced syncookies in the 90s and it shows. The fact that we've started abusing it for other things doesn't help. -- Mathematics is the supreme nostalgia of our time. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org