From: Namhyung Kim <namhyung@gmail.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Paul Menage <menage@google.com>, Li Zefan <lizf@cn.fujitsu.com>,
containers@lists.linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] memcg: move page-freeing code outside of lock
Date: Tue, 22 Mar 2011 19:06:57 +0900 [thread overview]
Message-ID: <1300788417.1492.2.camel@leonhard> (raw)
In-Reply-To: <20110322135619.90593f5d.kamezawa.hiroyu@jp.fujitsu.com>
2011-03-22 (i??), 13:56 +0900, KAMEZAWA Hiroyuki:
> On Tue, 22 Mar 2011 12:04:39 +0900
> Namhyung Kim <namhyung@gmail.com> wrote:
>
> > 2011-03-22 (i??), 08:59 +0900, KAMEZAWA Hiroyuki:
> > > On Fri, 18 Mar 2011 21:54:15 +0900
> > > Namhyung Kim <namhyung@gmail.com> wrote:
> > >
> > > > Signed-off-by: Namhyung Kim <namhyung@gmail.com>
> > > > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> > >
> > > What is the benefit of this patch ?
> > >
> > > -Kame
> > >
> >
> > Oh, I just thought generally it'd better call such a (potentially)
> > costly function outside of locks and it could reduce few of theoretical
> > contentions between swapons and/or offs. If it doesn't help any
> > realistic cases I don't mind discarding it.
> >
>
> My point is, please write patch description which shows for what this patc is.
> All cleanup are okay to me if it reasonable. But without patch description as
> "this is just a cleanup, no functional change, and the reason is...."
> we cannot maintain patches.
>
> Thanks,
> -Kame
>
OK, I will do that in the future. Anyway, do you want me to resend the
patch with new description?
Thanks.
--
Regards,
Namhyung Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-03-22 10:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 12:54 [PATCH 1/3] memcg: mark init_section_page_cgroup() properly Namhyung Kim
2011-03-18 12:54 ` [PATCH 2/3] memcg: fix off-by-one when calculating swap cgroup map length Namhyung Kim
2011-03-21 23:58 ` KAMEZAWA Hiroyuki
2011-03-22 3:13 ` Balbir Singh
2011-03-18 12:54 ` [PATCH 3/3] memcg: move page-freeing code outside of lock Namhyung Kim
2011-03-21 23:59 ` KAMEZAWA Hiroyuki
2011-03-22 3:04 ` Namhyung Kim
2011-03-22 3:09 ` Balbir Singh
2011-03-22 4:56 ` KAMEZAWA Hiroyuki
2011-03-22 10:06 ` Namhyung Kim [this message]
2011-03-23 4:36 ` KAMEZAWA Hiroyuki
2011-03-23 11:59 ` [PATCH] memcg: move page-freeing code out " Namhyung Kim
2011-03-23 23:37 ` KAMEZAWA Hiroyuki
2011-03-21 23:57 ` [PATCH 1/3] memcg: mark init_section_page_cgroup() properly KAMEZAWA Hiroyuki
2011-03-22 3:10 ` Balbir Singh
2011-04-01 1:18 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300788417.1492.2.camel@leonhard \
--to=namhyung@gmail.com \
--cc=containers@lists.linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).