From: Namhyung Kim <namhyung@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Paul Mundt <lethal@linux-sh.org>,
David Howells <dhowells@redhat.com>,
Greg Ungerer <gerg@snapgear.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH 5/6] nommu: fix a potential memory leak in do_mmap_private()
Date: Mon, 28 Mar 2011 22:56:46 +0900 [thread overview]
Message-ID: <1301320607-7259-6-git-send-email-namhyung@gmail.com> (raw)
In-Reply-To: <1301320607-7259-1-git-send-email-namhyung@gmail.com>
If f_op->read() fails and sysctl_nr_trim_pages > 1, there could be a
memory leak between @region->vm_end and @region->vm_top.
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
mm/nommu.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mm/nommu.c b/mm/nommu.c
index 33f5d23c6d44..662fd46449a6 100644
--- a/mm/nommu.c
+++ b/mm/nommu.c
@@ -1241,7 +1241,7 @@ static int do_mmap_private(struct vm_area_struct *vma,
return 0;
error_free:
- free_page_series(region->vm_start, region->vm_end);
+ free_page_series(region->vm_start, region->vm_top);
region->vm_start = vma->vm_start = 0;
region->vm_end = vma->vm_end = 0;
region->vm_top = 0;
--
1.7.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-03-28 13:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 13:56 [RFC/RFT 0/6] nommu: improve the vma list handling Namhyung Kim
2011-03-28 13:56 ` [PATCH 1/6] nommu: sort mm->mmap list properly Namhyung Kim
2011-03-31 18:51 ` Andrew Morton
2011-04-01 1:10 ` Namhyung Kim
2011-03-28 13:56 ` [PATCH 2/6] nommu: don't scan the vma list when deleting Namhyung Kim
2011-03-28 13:56 ` [PATCH 3/6] nommu: find vma using the sorted vma list Namhyung Kim
2011-03-28 13:56 ` [PATCH 4/6] nommu: check the vma list when unmapping file-mapped vma Namhyung Kim
2011-03-28 13:56 ` Namhyung Kim [this message]
2011-03-28 13:56 ` [PATCH 6/6] nommu: fix a compile warning in do_mmap_pgoff() Namhyung Kim
2011-03-28 22:01 ` [RFC/RFT 0/6] nommu: improve the vma list handling Andrew Morton
2011-03-31 4:56 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301320607-7259-6-git-send-email-namhyung@gmail.com \
--to=namhyung@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=gerg@snapgear.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).