From: Namhyung Kim <namhyung@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Paul Mundt <lethal@linux-sh.org>,
David Howells <dhowells@redhat.com>,
Greg Ungerer <gerg@snapgear.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH 6/6] nommu: fix a compile warning in do_mmap_pgoff()
Date: Mon, 28 Mar 2011 22:56:47 +0900 [thread overview]
Message-ID: <1301320607-7259-7-git-send-email-namhyung@gmail.com> (raw)
In-Reply-To: <1301320607-7259-1-git-send-email-namhyung@gmail.com>
Because 'ret' is declared as int, not unsigned long, no need to cast the
error contants into unsigned long. If you compile this code on a 64-bit
machine somehow, you'll see following warning:
CC mm/nommu.o
mm/nommu.c: In function a??do_mmap_pgoffa??:
mm/nommu.c:1411: warning: overflow in implicit constant conversion
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
mm/nommu.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/mm/nommu.c b/mm/nommu.c
index 662fd46449a6..c7af249076ac 100644
--- a/mm/nommu.c
+++ b/mm/nommu.c
@@ -1400,15 +1400,15 @@ unsigned long do_mmap_pgoff(struct file *file,
if (capabilities & BDI_CAP_MAP_DIRECT) {
addr = file->f_op->get_unmapped_area(file, addr, len,
pgoff, flags);
- if (IS_ERR((void *) addr)) {
+ if (IS_ERR_VALUE(addr)) {
ret = addr;
- if (ret != (unsigned long) -ENOSYS)
+ if (ret != -ENOSYS)
goto error_just_free;
/* the driver refused to tell us where to site
* the mapping so we'll have to attempt to copy
* it */
- ret = (unsigned long) -ENODEV;
+ ret = -ENODEV;
if (!(capabilities & BDI_CAP_MAP_COPY))
goto error_just_free;
--
1.7.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-03-28 13:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 13:56 [RFC/RFT 0/6] nommu: improve the vma list handling Namhyung Kim
2011-03-28 13:56 ` [PATCH 1/6] nommu: sort mm->mmap list properly Namhyung Kim
2011-03-31 18:51 ` Andrew Morton
2011-04-01 1:10 ` Namhyung Kim
2011-03-28 13:56 ` [PATCH 2/6] nommu: don't scan the vma list when deleting Namhyung Kim
2011-03-28 13:56 ` [PATCH 3/6] nommu: find vma using the sorted vma list Namhyung Kim
2011-03-28 13:56 ` [PATCH 4/6] nommu: check the vma list when unmapping file-mapped vma Namhyung Kim
2011-03-28 13:56 ` [PATCH 5/6] nommu: fix a potential memory leak in do_mmap_private() Namhyung Kim
2011-03-28 13:56 ` Namhyung Kim [this message]
2011-03-28 22:01 ` [RFC/RFT 0/6] nommu: improve the vma list handling Andrew Morton
2011-03-31 4:56 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301320607-7259-7-git-send-email-namhyung@gmail.com \
--to=namhyung@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=gerg@snapgear.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).