linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Maxin John <maxin.john@gmail.com>
Cc: Daniel Baluta <dbaluta@ixiacom.com>,
	naveen yadav <yad.naveen@gmail.com>,
	linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: kmemleak for MIPS
Date: Wed, 30 Mar 2011 10:15:05 +0100	[thread overview]
Message-ID: <1301476505.29074.47.camel@e102109-lin.cambridge.arm.com> (raw)
In-Reply-To: <AANLkTi=gMP6jQuQFovfsOX=7p-SSnwXoVLO_DVEpV63h@mail.gmail.com>

On Tue, 2011-03-29 at 20:36 +0100, Maxin John wrote:
> I have prepared the combined patch for kmemleak porting to MIPS. After
> applying the patch and enabling the kmemleak in Kernel, I can see one
> kernel memleak reported during booting itself:
...
> unreferenced object 0x8f90d000 (size 4096):
>   comm "swapper", pid 1, jiffies 4294937330 (age 815.000s)
>   hex dump (first 32 bytes):
>     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
>     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
>   backtrace:
>     [<80529644>] alloc_large_system_hash+0x2f8/0x410
>     [<805383b4>] udp_table_init+0x4c/0x158
>     [<805384dc>] udp_init+0x1c/0x94
>     [<8053889c>] inet_init+0x184/0x2a0
>     [<80100584>] do_one_initcall+0x174/0x1e0
>     [<8051f348>] kernel_init+0xe4/0x174
>     [<80103d4c>] kernel_thread_helper+0x10/0x18

If you for the kmemleak scan (via echo) a few times, do you get more
leaks? The udp_table_init() function looks like it could leak some
memory but I haven't seen it before. I'm not sure whether this is a
false positive or a real leak.
> 
> Please let me know your comments.
> 
> Signed-off-by: Maxin B. John <maxin.john@gmail.com>
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>

I think the last line should be more like:

Acked-by: Catalin Marinas <catalin.marinas@arm.com>


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2011-03-30  9:15 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-02 13:54 kmemleak for MIPS naveen yadav
2011-03-24  9:27 ` Daniel Baluta
2011-03-24  9:55   ` Catalin Marinas
2011-03-28 21:15     ` Maxin John
2011-03-29 10:40       ` Catalin Marinas
2011-03-29 11:38         ` Maxin John
2011-03-29 11:50           ` Catalin Marinas
2011-03-29 12:27             ` Maxin John
2011-03-29 19:36               ` Maxin John
2011-03-29 19:54                 ` Daniel Baluta
2011-03-30  9:15                 ` Catalin Marinas [this message]
2011-03-30  9:54                   ` Daniel Baluta
2011-03-30  9:58                     ` Catalin Marinas
2011-03-30 11:03                     ` Maxin John
2011-03-30 11:24                       ` Daniel Baluta
2011-03-30 11:38                         ` Catalin Marinas
2011-03-30 12:17                           ` Maxin John
2011-03-30 12:27                             ` Eric Dumazet
2011-03-30 12:40                               ` Maxin John
2011-03-30 12:52                               ` Daniel Baluta
2011-03-30 13:17                                 ` Maxin John
2011-03-30 13:27                                   ` Eric Dumazet
2011-03-30 14:07                                     ` Maxin John
2011-03-30 14:07                                     ` Catalin Marinas
2011-03-30 12:22                         ` Eric Dumazet
2011-03-30 10:08                   ` Maxin John
2011-03-30 14:28                 ` Ralf Baechle
2011-03-30 14:21         ` Ralf Baechle
  -- strict thread matches above, loose matches on Subject: below --
2009-11-02 17:07 Kmemleak for mips Luis R. Rodriguez
2009-11-03  9:23 ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1301476505.29074.47.camel@e102109-lin.cambridge.arm.com \
    --to=catalin.marinas@arm.com \
    --cc=dbaluta@ixiacom.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-mm@kvack.org \
    --cc=maxin.john@gmail.com \
    --cc=yad.naveen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).