From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with ESMTP id 78ABA8D0040 for ; Thu, 31 Mar 2011 21:19:10 -0400 (EDT) Received: by iyf13 with SMTP id 13so4263264iyf.14 for ; Thu, 31 Mar 2011 18:19:08 -0700 (PDT) Subject: Re: [PATCH 1/3] memcg: mark init_section_page_cgroup() properly From: Namhyung Kim In-Reply-To: <1300452855-10194-1-git-send-email-namhyung@gmail.com> References: <1300452855-10194-1-git-send-email-namhyung@gmail.com> Content-Type: text/plain; charset="UTF-8" Date: Fri, 01 Apr 2011 10:18:56 +0900 Message-ID: <1301620736.1496.9.camel@leonhard> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Paul Menage , Li Zefan , containers@lists.linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, KAMEZAWA Hiroyuki 2011-03-18 (e,?), 21:54 +0900, Namhyung Kim: > The commit ca371c0d7e23 ("memcg: fix page_cgroup fatal error > in FLATMEM") removes call to alloc_bootmem() in the function > so that it can be marked as __meminit to reduce memory usage > when MEMORY_HOTPLUG=n. > > Signed-off-by: Namhyung Kim > Cc: KAMEZAWA Hiroyuki > --- > mm/page_cgroup.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/mm/page_cgroup.c b/mm/page_cgroup.c > index 5bffada7cde1..2d1a0fa01d7b 100644 > --- a/mm/page_cgroup.c > +++ b/mm/page_cgroup.c > @@ -105,8 +105,7 @@ struct page_cgroup *lookup_page_cgroup(struct page *page) > return section->page_cgroup + pfn; > } > > -/* __alloc_bootmem...() is protected by !slab_available() */ > -static int __init_refok init_section_page_cgroup(unsigned long pfn) > +static int __meminit init_section_page_cgroup(unsigned long pfn) > { > struct mem_section *section = __pfn_to_section(pfn); > struct page_cgroup *base, *pc; Andrew, could you please have a look these patches too and consider applying them in your tree? I can resend them (with given Acked-by lines) if you want. Thanks. -- Regards, Namhyung Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org