From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Michel Lespinasse <walken@google.com>
Cc: linux-mm@kvack.org, KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [PATCH 2/5] kstaled: page_referenced_kstaled() and supporting infrastructure.
Date: Wed, 06 Apr 2011 16:22:42 -0700 [thread overview]
Message-ID: <1302132162.8184.517.camel@nimitz> (raw)
In-Reply-To: <1301042635-11180-3-git-send-email-walken@google.com>
On Fri, 2011-03-25 at 01:43 -0700, Michel Lespinasse wrote:
> +PAGEFLAG(Young, young)
> +
> +PAGEFLAG(Idle, idle)
> +
> +static inline void set_page_young(struct page *page)
> +{
> + if (!PageYoung(page))
> + SetPageYoung(page);
> +}
> +
> +static inline void clear_page_idle(struct page *page)
> +{
> + if (PageIdle(page))
> + ClearPageIdle(page);
> +}
Is it time for a CONFIG_X86_32_STRUCT_PAGE_IS_NOW_A_BLOATED_BIG config
option? If folks want these kinds of features, then they need to suck
it up and make their 'struct page' 36 bytes. Any of these new page
flags features could:
config EXTENDED_PAGE_FLAGS
depends on 64BIT || X86_32_STRUCT_PAGE_IS_NOW_A_BLOATED_BIG
config KSTALED
depends on EXTENDED_PAGE_FLAGS
And then we can wrap the "enum pageflags" entries for them in #ifdefs,
along with making page->flags a u64 when
X86_32_STRUCT_PAGE_IS_NOW_A_BLOATED_BIG is set.
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-04-06 23:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-25 8:43 [RFC 0/5] idle page tracking / working set estimation Michel Lespinasse
2011-03-25 8:43 ` [PATCH 1/5] page_referenced: replace vm_flags parameter with struct pr_info Michel Lespinasse
2011-03-25 8:43 ` [PATCH 2/5] kstaled: page_referenced_kstaled() and supporting infrastructure Michel Lespinasse
2011-04-06 23:22 ` Dave Hansen [this message]
2011-04-07 7:15 ` KOSAKI Motohiro
2011-03-25 8:43 ` [PATCH 3/5] kstaled: minimalistic implementation Michel Lespinasse
2011-03-25 8:43 ` [PATCH 4/5] kstaled: skip non-RAM regions Michel Lespinasse
2011-03-25 8:43 ` [PATCH 5/5] kstaled: rate limit pages scanned per second Michel Lespinasse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302132162.8184.517.camel@nimitz \
--to=dave@linux.vnet.ibm.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).