From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with ESMTP id 451208D003B for ; Fri, 8 Apr 2011 09:19:57 -0400 (EDT) Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by e31.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p38D4ERk022063 for ; Fri, 8 Apr 2011 07:04:14 -0600 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p38DJndo111510 for ; Fri, 8 Apr 2011 07:19:49 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p38DJmuP029423 for ; Fri, 8 Apr 2011 07:19:49 -0600 Subject: Re: [PATCH 2/2] make new alloc_pages_exact() From: Dave Hansen In-Reply-To: References: <20110407172104.1F8B7329@kernel> <20110407172105.831B9A0A@kernel> Content-Type: text/plain; charset="ISO-8859-1" Date: Fri, 08 Apr 2011 06:19:46 -0700 Message-ID: <1302268786.8184.6879.camel@nimitz> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Nazarewicz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Timur Tabi , Andi Kleen , Mel Gorman , Andrew Morton On Fri, 2011-04-08 at 14:28 +0200, Michal Nazarewicz wrote: > On Thu, 07 Apr 2011 19:21:05 +0200, Dave Hansen > wrote: > > +struct page *__alloc_pages_exact(gfp_t gfp_mask, size_t size) > > { > > unsigned int order = get_order(size); > > - unsigned long addr; > > + struct page *page; > > - addr = __get_free_pages(gfp_mask, order); > > - if (addr) { > > - unsigned long alloc_end = addr + (PAGE_SIZE << order); > > - unsigned long used = addr + PAGE_ALIGN(size); > > + page = alloc_pages(gfp_mask, order); > > + if (page) { > > + struct page *alloc_end = page + (1 << order); > > + struct page *used = page + PAGE_ALIGN(size)/PAGE_SIZE; > > - split_page(virt_to_page((void *)addr), order); > > + split_page(page, order); > > while (used < alloc_end) { > > - free_page(used); > > - used += PAGE_SIZE; > > + __free_page(used); > > + used++; > > } > > Have you thought about moving this loop to a separate function, ie. > _free_page_range(start, end)? I'm asking because this loop appears > in two places and my CMA would also benefit from such a function. Sounds like a good idea to me. Were you thinking start/end 'struct page's as arguments? -- Dave -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org