From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Michal Nazarewicz <mina86@mina86.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Timur Tabi <timur@freescale.com>,
Andi Kleen <andi@firstfloor.org>, Mel Gorman <mel@csn.ul.ie>,
David Rientjes <rientjes@google.com>
Subject: Re: [PATCH 2/3] make new alloc_pages_exact()
Date: Wed, 13 Apr 2011 16:23:29 -0700 [thread overview]
Message-ID: <1302737009.14658.3848.camel@nimitz> (raw)
In-Reply-To: <op.vtt1clbd3l0zgt@mnazarewicz-glaptop>
On Tue, 2011-04-12 at 17:58 +0200, Michal Nazarewicz wrote:
> > Actually, the various mem_map[]s _are_ arrays, at least up to
> > MAX_ORDER_NR_PAGES at a time. We can use that property here.
>
> In that case, waiting eagerly for the new patch. :)
I misunderstood earlier. release_pages() takes an array of 'struct page
*', not an array of 'struct page'. To use it here, we'd need to
construct temporary arrays. If we're going to do that, we should
probably just use pagevecs, and if we're going to do _that_, we don't
need release_pages().
Nobody calls free_pages_exact() in any kind of hot path these days.
Most of the users are like kernel profiling where they *never* free the
memory. I'm not sure it's worth the complexity to optimize this.
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-04-13 23:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 22:03 [PATCH 1/3] rename alloc_pages_exact() Dave Hansen
2011-04-11 22:03 ` [PATCH 2/3] make new alloc_pages_exact() Dave Hansen
2011-04-11 22:22 ` Andrew Morton
2011-04-11 22:36 ` Dave Hansen
2011-04-11 22:42 ` Timur Tabi
2011-04-12 10:28 ` Michal Nazarewicz
2011-04-12 15:04 ` Dave Hansen
2011-04-12 15:58 ` Michal Nazarewicz
2011-04-13 23:23 ` Dave Hansen [this message]
2011-04-11 22:03 ` [PATCH 3/3] reuse __free_pages_exact() in __alloc_pages_exact() Dave Hansen
2011-04-12 10:29 ` Michal Nazarewicz
2011-04-12 15:24 ` Dave Hansen
2011-04-12 15:57 ` Michal Nazarewicz
2011-04-12 17:07 ` [PATCH 1/3] rename alloc_pages_exact() Namhyung Kim
2011-04-12 17:11 ` Dave Hansen
-- strict thread matches above, loose matches on Subject: below --
2011-04-14 20:01 Dave Hansen
2011-04-14 20:01 ` [PATCH 2/3] make new alloc_pages_exact() Dave Hansen
2011-04-14 21:55 ` David Rientjes
2011-04-27 21:30 ` Timur Tabi
2011-04-27 21:37 ` Dave Hansen
2011-04-27 21:42 ` Timur Tabi
2011-04-28 16:02 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302737009.14658.3848.camel@nimitz \
--to=dave@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=mina86@mina86.com \
--cc=rientjes@google.com \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).