From: Dave Hansen <dave@linux.vnet.ibm.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-sparse@vger.kernel.org
Subject: Re: [PATCH] fix sparse happy borkage when including gfp.h
Date: Fri, 15 Apr 2011 07:27:54 -0700 [thread overview]
Message-ID: <1302877674.16562.3089.camel@nimitz> (raw)
In-Reply-To: <20110415143259.F7BD.A69D9226@jp.fujitsu.com>
On Fri, 2011-04-15 at 14:33 +0900, KOSAKI Motohiro wrote:
> Hello,
> > On Fri, 2011-04-15 at 12:14 +0900, KOSAKI Motohiro wrote:
> > > > #ifdef CONFIG_DEBUG_VM
> > > > - BUG_ON((GFP_ZONE_BAD >> bit) & 1);
> > > > + BUG_ON((GFP_ZONE_BAD >> bit) & 1);
> > > > #endif
> > > > - }
> > > > return z;
> > >
> > > Why don't you use VM_BUG_ON?
> >
> > I was just trying to make a minimal patch that did a single thing.
> >
> > Feel free to submit another one that does that. I'm sure there are a
> > couple more places that could use similar love.
>
> I posted another approach patches a second ago. Could you please see it?
Those both look sane to me. Those weren't biting me in particular, and
they don't fix the issue I was seeing. But, they do seem necessary to
reduce some of the noise.
CC'ing the sparse mailing list. We're seeing a couple of cases where
some gcc-isms are either stopping sparse from finding real bugs:
http://marc.info/?l=linux-mm&m=130282454732689&w=2
or creating a lot of noise on some builds:
http://marc.info/?l=linux-mm&m=130284428614058&w=2
http://marc.info/?l=linux-mm&m=130284431014077&w=2
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-04-15 14:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-14 23:42 [PATCH] make sparse happy with gfp.h Dave Hansen
2011-04-15 3:14 ` KOSAKI Motohiro
2011-04-15 5:07 ` Dave Hansen
2011-04-15 5:33 ` KOSAKI Motohiro
2011-04-15 14:27 ` Dave Hansen [this message]
2011-04-15 5:09 ` [PATCH] define dummy BUILD_BUG_ON definition for sparse KOSAKI Motohiro
2011-04-15 5:11 ` [PATCH] define __must_be_array() for __CHECKER__ KOSAKI Motohiro
2011-04-15 5:11 ` [PATCH] Undef __compiletime_{warning,error} if __CHECKER__ is defined KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302877674.16562.3089.camel@nimitz \
--to=dave@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).