From: Ying Han <yinghan@google.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Minchan Kim <minchan.kim@gmail.com>,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Tejun Heo <tj@kernel.org>, Pavel Emelyanov <xemul@openvz.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Li Zefan <lizf@cn.fujitsu.com>, Mel Gorman <mel@csn.ul.ie>,
Christoph Lameter <cl@linux.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Rik van Riel <riel@redhat.com>, Hugh Dickins <hughd@google.com>,
Michal Hocko <mhocko@suse.cz>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Zhu Yanhai <zhu.yanhai@gmail.com>
Cc: linux-mm@kvack.org
Subject: [PATCH V5 09/10] Add API to export per-memcg kswapd pid.
Date: Fri, 15 Apr 2011 16:23:34 -0700 [thread overview]
Message-ID: <1302909815-4362-10-git-send-email-yinghan@google.com> (raw)
In-Reply-To: <1302909815-4362-1-git-send-email-yinghan@google.com>
This add the API which exports per-memcg kswapd thread pid. The kswapd
thread is named as "memcg_" + css_id, and the pid can be used to put
kswapd thread into cpu cgroup later.
$ mkdir /dev/cgroup/memory/A
$ cat /dev/cgroup/memory/A/memory.kswapd_pid
memcg_null 0
$ echo 500m >/dev/cgroup/memory/A/memory.limit_in_bytes
$ echo 50m >/dev/cgroup/memory/A/memory.high_wmark_distance
$ ps -ef | grep memcg
root 6727 2 0 14:32 ? 00:00:00 [memcg_3]
root 6729 6044 0 14:32 ttyS0 00:00:00 grep memcg
$ cat memory.kswapd_pid
memcg_3 6727
changelog v5..v4
1. Initialize the memcg-kswapd pid to -1 instead of 0.
2. Remove the kswapds_spinlock.
changelog v4..v3
1. Add the API based on KAMAZAWA's request on patch v3.
Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Signed-off-by: Ying Han <yinghan@google.com>
---
include/linux/swap.h | 2 ++
mm/memcontrol.c | 31 +++++++++++++++++++++++++++++++
2 files changed, 33 insertions(+), 0 deletions(-)
diff --git a/include/linux/swap.h b/include/linux/swap.h
index 319b800..2d3e21a 100644
--- a/include/linux/swap.h
+++ b/include/linux/swap.h
@@ -34,6 +34,8 @@ struct kswapd {
};
int kswapd(void *p);
+extern spinlock_t kswapds_spinlock;
+
/*
* MAX_SWAPFILES defines the maximum number of swaptypes: things which can
* be swapped to. The swap type and the offset into that swap type are
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 52e8344..347e861 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -4526,6 +4526,33 @@ static int mem_cgroup_wmark_read(struct cgroup *cgrp,
return 0;
}
+static int mem_cgroup_kswapd_pid_read(struct cgroup *cgrp,
+ struct cftype *cft, struct cgroup_map_cb *cb)
+{
+ struct mem_cgroup *mem = mem_cgroup_from_cont(cgrp);
+ struct task_struct *kswapd_thr = NULL;
+ struct kswapd *kswapd_p = NULL;
+ wait_queue_head_t *wait;
+ char name[TASK_COMM_LEN];
+ pid_t pid = -1;
+
+ sprintf(name, "memcg_null");
+
+ wait = mem_cgroup_kswapd_wait(mem);
+ if (wait) {
+ kswapd_p = container_of(wait, struct kswapd, kswapd_wait);
+ kswapd_thr = kswapd_p->kswapd_task;
+ if (kswapd_thr) {
+ get_task_comm(name, kswapd_thr);
+ pid = kswapd_thr->pid;
+ }
+ }
+
+ cb->fill(cb, name, pid);
+
+ return 0;
+}
+
static int mem_cgroup_oom_control_read(struct cgroup *cgrp,
struct cftype *cft, struct cgroup_map_cb *cb)
{
@@ -4643,6 +4670,10 @@ static struct cftype mem_cgroup_files[] = {
.name = "reclaim_wmarks",
.read_map = mem_cgroup_wmark_read,
},
+ {
+ .name = "kswapd_pid",
+ .read_map = mem_cgroup_kswapd_pid_read,
+ },
};
#ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP
--
1.7.3.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-04-15 23:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 23:23 [PATCH V5 00/10] memcg: per cgroup background reclaim Ying Han
2011-04-15 23:23 ` [PATCH V5 01/10] Add kswapd descriptor Ying Han
2011-04-18 0:57 ` Minchan Kim
2011-04-18 18:09 ` Ying Han
2011-04-19 5:35 ` Minchan Kim
2011-04-15 23:23 ` [PATCH V5 02/10] Add per memcg reclaim watermarks Ying Han
2011-04-15 23:23 ` [PATCH V5 03/10] New APIs to adjust per-memcg wmarks Ying Han
2011-04-15 23:23 ` [PATCH V5 04/10] Infrastructure to support per-memcg reclaim Ying Han
2011-04-18 2:11 ` Minchan Kim
2011-04-18 18:44 ` Ying Han
2011-04-15 23:23 ` [PATCH V5 05/10] Implement the select_victim_node within memcg Ying Han
2011-04-18 2:22 ` Minchan Kim
2011-04-18 17:11 ` Ying Han
2011-04-15 23:23 ` [PATCH V5 06/10] Per-memcg background reclaim Ying Han
2011-04-18 3:51 ` Minchan Kim
2011-04-18 21:38 ` Ying Han
2011-04-18 23:32 ` Minchan Kim
2011-04-19 2:42 ` Ying Han
2011-04-19 5:50 ` Minchan Kim
2011-04-15 23:23 ` [PATCH V5 07/10] Add per-memcg zone "unreclaimable" Ying Han
2011-04-18 4:27 ` Minchan Kim
2011-04-18 17:31 ` Ying Han
2011-04-15 23:23 ` [PATCH V5 08/10] Enable per-memcg background reclaim Ying Han
2011-04-15 23:23 ` Ying Han [this message]
2011-04-18 5:01 ` [PATCH V5 09/10] Add API to export per-memcg kswapd pid Minchan Kim
2011-04-18 17:41 ` Ying Han
2011-04-15 23:23 ` [PATCH V5 10/10] Add some per-memcg stats Ying Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302909815-4362-10-git-send-email-yinghan@google.com \
--to=yinghan@google.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=cl@linux.com \
--cc=dave@linux.vnet.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=mel@csn.ul.ie \
--cc=mhocko@suse.cz \
--cc=minchan.kim@gmail.com \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=riel@redhat.com \
--cc=tj@kernel.org \
--cc=xemul@openvz.org \
--cc=zhu.yanhai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).