From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B92B7C761A6 for ; Mon, 3 Apr 2023 07:49:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F2C66B0075; Mon, 3 Apr 2023 03:49:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A1856B0074; Mon, 3 Apr 2023 03:49:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 342346B0075; Mon, 3 Apr 2023 03:49:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 252FE6B0072 for ; Mon, 3 Apr 2023 03:49:42 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 95CE0C08EA for ; Mon, 3 Apr 2023 07:49:41 +0000 (UTC) X-FDA: 80639305362.05.DA76DF8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 69DE820013 for ; Mon, 3 Apr 2023 07:49:39 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RsFcW9WL; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680508179; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wjW3+Ysmamg9knSlqi+igsm5XB/oTir+s+7kEVE5SVw=; b=BKyqdCNSJaLAK5A21oIfVYeKLrWUEvFWbGf7ePqtpApJY5ttCL78iiipRRlLFbFYv/Je9Q cG+RB0d5h4B8OTNF3cw9W2VEULu1O16qLlqIVrzypuU07gY3fUb4Gw6bV/3kutTSErx0Ai ksjrjelx1TQ0LEGMO8EH1ItcTCjpKDQ= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RsFcW9WL; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680508179; a=rsa-sha256; cv=none; b=n+8BzHK2ahboGB5ti78WpP0lgT2TbCxloTplRHXBVTXIGcmfAaoI6eqbaKmqABpMGYaGhp 3ZUh6qoRJkAaKc29IvMXHDjLhLGluJQiandji6r7Hxpf0eo4Q5O2RkjTO9w+KfOzhlfsmC M6PJFtbyXwf4Jhvykxd87hiVGYEg6l8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680508178; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wjW3+Ysmamg9knSlqi+igsm5XB/oTir+s+7kEVE5SVw=; b=RsFcW9WLG7oYZP2ZkcQl5jrGFircEHamBFzF3cW6whVb9/1lGrR5mDhQFXI/XM2+nSwzqb kCFYtdS4NAxc+/IrxrBooSEIFr3EcGHWzdpcVO1rwPrWBGYFv738ccBuH5W4wXrynAvEG+ y+JhBoKb/iDopk61wP3GrZE1JMwSDgw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-471-sFsPhk4jNKCAMe1h1MWpew-1; Mon, 03 Apr 2023 03:49:37 -0400 X-MC-Unique: sFsPhk4jNKCAMe1h1MWpew-1 Received: by mail-wm1-f71.google.com with SMTP id v7-20020a05600c470700b003ef6ebfa99fso11116540wmo.8 for ; Mon, 03 Apr 2023 00:49:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680508176; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wjW3+Ysmamg9knSlqi+igsm5XB/oTir+s+7kEVE5SVw=; b=A7gfWMyl+6MGA4pRdQ3rMbDjZPWNhMwXOrfhf/Qk0+AnxnFtUz01k7Owjv8rYeGbER Jh85ff0TXDcyAX40gMpSE1X+ZJgAtBFR/v0FhNwSZjARe8c+van8UU/5FnOc9cbGvrT3 978USYwI85NHjSmRCEMVqJMDWVEqGZ72Z3z/ONqocMWZtIBtyq6j4IQkyxb7+P2dJ74B frgMIEIw8Uh2f/muPFkw6zXP+2d/qvpqGDEcRuTEA++lLERcldJNr9J6/OP/DupEqTbu HvueWNx+tHW8Cxloi09gejxAzQb7RYmsrPpzm8V2LmIYSmbNP9RQvtvZ5VIxeorWty8/ 31Fg== X-Gm-Message-State: AAQBX9eMnnfNAuPVYd8O0NEUJBN+Wm8+hQdhuv0v5JUNc7n+39urMZ6a YrGwMXFvmg1mqe33I2p4+Iftsiu/i81L1IfQ4XjRHtSZcqh1lc0V2dGi+VIjLkdHj2QqU0W47Ss 2zYJxUJBJAT8= X-Received: by 2002:adf:e852:0:b0:2c5:3ccf:e99a with SMTP id d18-20020adfe852000000b002c53ccfe99amr24238300wrn.6.1680508176456; Mon, 03 Apr 2023 00:49:36 -0700 (PDT) X-Google-Smtp-Source: AKy350ZnCEBfH/ofvOkEZtKbNH3snyGXtIuWExjv90T1NxL5qT/FRv/QUNsnfB3kxrSTPpIqPuwqFQ== X-Received: by 2002:adf:e852:0:b0:2c5:3ccf:e99a with SMTP id d18-20020adfe852000000b002c53ccfe99amr24238280wrn.6.1680508176157; Mon, 03 Apr 2023 00:49:36 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:5e00:8e78:71f3:6243:77f0? (p200300cbc7025e008e7871f3624377f0.dip0.t-ipconnect.de. [2003:cb:c702:5e00:8e78:71f3:6243:77f0]) by smtp.gmail.com with ESMTPSA id p2-20020a5d48c2000000b002e61923575csm8307835wrs.74.2023.04.03.00.49.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Apr 2023 00:49:35 -0700 (PDT) Message-ID: <1303d6f3-bc9a-ea17-3cd3-3e44891291dc@redhat.com> Date: Mon, 3 Apr 2023 09:49:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 03/29] selftests/mm: Dump a summary in run_vmtests.sh To: Peter Xu , Axel Rasmussen Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Andrea Arcangeli , Mike Kravetz , Leonardo Bras Soares Passos , Mike Rapoport , Nadav Amit References: <20230330155707.3106228-1-peterx@redhat.com> <20230330160646.3106903-1-peterx@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 69DE820013 X-Stat-Signature: ojgw3wgg7aze8tktj5nonxzk4hmw6q4e X-HE-Tag: 1680508179-951137 X-HE-Meta: U2FsdGVkX19oaTEAAEGic0kQPCs1Gtkq7yEHWrrJTBK2kkF4HlkFdN3pDWlBksxefhkLCDBiM0epov401P1unLgmoQcRMvXmlUjObEaC8yrKC+uZyJWhNUJ3o/KF0TPVcm7BQBa3yNTDVXrqfBzJktbFZnAJA0Y23BQmO0Oz1q97KwQzE4yBeHErV51xQI6ga1c0BUT0C4z/BbiR6tY4v5GGRgdcxD5T9UaGoBVhr2HwmNvqnUrwdtHvX6sZWJ+he/nz7GuF3rjryqkyGX9LedkKhqCwT7sZdC9il0DePSs3ihO5CvFJY5f+pBYNiv7CxDstX1qslRK29hCxyycz3DKrh6cyhlOpgxUM8YlAEinsNTwBEVGQvPr6d/09upTDKd+sGdrKNdlO5bVfMk1AvHgwOk/sQOC89o1plYk/Be8+AOB1PDdj4IUEv2XFwAuXqUOdkbZ4anb2VW8CKZNNEqztDrD6+3yagPOx1HLyJFZTH2PgCthnDBMPAjWWVhKjs7k0K+nZVqgmzQcprx9ijDwXFBg40DRcpb/asE/gb/nGaToOSbanajveyL1QPJ7S7Yd3t58b3+NjLzyE5eC2WVFu97l+xOjPMCVNmcLlW3srSuMcGVqeX9k78rApjJoSDmGdFlghLyDAG0uBmiUAgjKfEmpiELA/pYs9+FioHPYtQipcy3KCdmN7hqciGW6RsYBNMBW9XfnjcAIXI2k6Ka8gZaxeSrqOI1dr8PKrdl1e5VT4Q3Sid9lOyTiEMzAc239EOOtPU/C1fBer6DbfB98PFBmSyAHbYsFkhZGtIuI9zQmiHgQSUwpr8fq14Dn6Ejn9G2hwvaEHqXfo1Y6rUd/N3WQfTjdgkqSPJ7xW2i9+OT012YhPcRIDCfQYl1bLykrtBT39GfVe3yYr8FDTaB4h2qPcRw5jR/Zl9vgeroujFbW94Y6xnogDSkfRJbjyD1Ye5ua4s6xEgFYfeYM 40yT265/ Js/zvlVFoU8lkIGT6bWX077NfCGM4qr50K4/0/U+ABN/61M0HPc4kY7vZVQrY846P7kRTTl/m3dTyXVWp1yKwam3aM7HYkjS9ZBvWUXwMB+yx+6SnKkwwDuvQY5BzfIYjhOwVcUzMO+D2zXrNkb/X+tl1GoJsBS7LOc69DTPb5kdhTD5ZW6V56i7bNZ6IJr5FR+yHXcA63dKoJQzNf7it2reVXrcodU6+P7GHH9ewx8+DFWUERPLaMBjsjv42oCxUvSAdat9PuvR14fVO6igU7KIrS5rNV/DAb/7LmMBGYAkK7jveOHZ4qeQ1mooVLnVJyKdm2OcWkTDSgmmNN0zEkthDnF+b92UyS8c4nEsYrFsjVdC3zG+yJE138jp9dPDITPbjHmaHJzBSBZ36OqJdQNPXuVQCOw8GdVm7f6TQHHIp+EGWfqXYZCooFWquEbEB5hVR/ab0hBRO7f4qgaSfb5/WZ4M7dLsdfWhI04TssPwQ6aDeHcR41UvMc/meqERR2Or3ipkKmb9MI6RHtbk6x1lA+0Z5IhECu4cW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000016, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 31.03.23 00:28, Peter Xu wrote: > On Thu, Mar 30, 2023 at 12:07:24PM -0700, Axel Rasmussen wrote: >> On Thu, Mar 30, 2023 at 9:06 AM Peter Xu wrote: >>> >>> Dump a summary after running whatever test specified. Useful for human >>> runners to identify any kind of failures (besides exit code). >>> >>> Signed-off-by: Peter Xu >>> --- >>> tools/testing/selftests/mm/run_vmtests.sh | 8 ++++++++ >>> 1 file changed, 8 insertions(+) >>> >>> diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh >>> index c0f93b668c0c..9cc33984aa9f 100644 >>> --- a/tools/testing/selftests/mm/run_vmtests.sh >>> +++ b/tools/testing/selftests/mm/run_vmtests.sh >>> @@ -5,6 +5,9 @@ >>> # Kselftest framework requirement - SKIP code is 4. >>> ksft_skip=4 >>> >>> +count_pass=0 >>> +count_fail=0 >>> +count_skip=0 >>> exitcode=0 >>> >>> usage() { >>> @@ -149,11 +152,14 @@ run_test() { >>> "$@" >>> local ret=$? >>> if [ $ret -eq 0 ]; then >>> + count_pass=$(( $count_pass + 1 )) >> >> Actually, inside $(( )) there's no need to prefix variable names with >> $ too. Running "shellcheck" over the script written this way will >> generate a warning. >> >> Same applies below. > > Sure, I'll fix. With that Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb