* [PATCH 4/4] mm: Do not define PFN_SECTION_SHIFT if !CONFIG_SPARSEMEM
@ 2011-05-02 21:22 Daniel Kiper
2011-05-03 16:10 ` Dave Hansen
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Kiper @ 2011-05-02 21:22 UTC (permalink / raw)
To: ian.campbell, akpm, andi.kleen, haicheng.li, fengguang.wu, jeremy,
konrad.wilk, dan.magenheimer, v.tolstov, pasik, dave, wdauchy,
rientjes, xen-devel, linux-kernel, linux-mm
Do not define PFN_SECTION_SHIFT if !CONFIG_SPARSEMEM.
Signed-off-by: Daniel Kiper <dkiper@net-space.pl>
---
include/linux/mm.h | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 23465e1..d1f8cb4 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -603,10 +603,6 @@ static inline pte_t maybe_mkwrite(pte_t pte, struct vm_area_struct *vma)
#define NODE_NOT_IN_PAGE_FLAGS
#endif
-#ifndef PFN_SECTION_SHIFT
-#define PFN_SECTION_SHIFT 0
-#endif
-
/*
* Define the bit shifts to access each section. For non-existent
* sections we define the shift as 0; that plus a 0 mask ensures
--
1.5.6.5
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 4/4] mm: Do not define PFN_SECTION_SHIFT if !CONFIG_SPARSEMEM
2011-05-02 21:22 [PATCH 4/4] mm: Do not define PFN_SECTION_SHIFT if !CONFIG_SPARSEMEM Daniel Kiper
@ 2011-05-03 16:10 ` Dave Hansen
0 siblings, 0 replies; 2+ messages in thread
From: Dave Hansen @ 2011-05-03 16:10 UTC (permalink / raw)
To: Daniel Kiper
Cc: ian.campbell, akpm, andi.kleen, haicheng.li, fengguang.wu, jeremy,
konrad.wilk, dan.magenheimer, v.tolstov, pasik, wdauchy, rientjes,
xen-devel, linux-kernel, linux-mm
On Mon, 2011-05-02 at 23:22 +0200, Daniel Kiper wrote:
> Do not define PFN_SECTION_SHIFT if !CONFIG_SPARSEMEM.
>
> Signed-off-by: Daniel Kiper <dkiper@net-space.pl>
I'd like if this was a bit easier to verify that it didn't break
anything. Basically, we should probably limit direct use of
PFN_SECTION_SHIFT to inside #ifdefs in headers.
But, if something is truly using this today, it's probably broken. It's
easy enough to work around if someone hits it, I guess.
Acked-by: Dave Hansen <dave@linux.vnet.ibm.com>
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-05-03 16:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-02 21:22 [PATCH 4/4] mm: Do not define PFN_SECTION_SHIFT if !CONFIG_SPARSEMEM Daniel Kiper
2011-05-03 16:10 ` Dave Hansen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).