Re: [PATCH 2/3] printk: Add %ptc to safely print a task's comm

David Rientjes
2011-05-12T22:12:41Z

On Tue, 10 May 2011, Joe Perches wrote:

> > Although I'm not sure if there's precedent for a %p value that didn't
> > take a argument. Thoughts on that? Anyone else have an opinion here?
>
> The uses of %ptc must add an argument or else gcc will complain.
> I suggest you just ignore the argument value and use current.
>

That doesn't make any sense, why would you needlessly restrict this to
current when accesses to other threads' ->comm needs to be protected in
the same way? I'd like to use this in the oom killer and try to get rid
of taking task_lock() for every thread group leader in the tasklist dump.