From: Joe Perches <joe@perches.com>
To: Michal Nazarewicz <mina86@mina86.com>
Cc: David Rientjes <rientjes@google.com>,
Andy Whitcroft <apw@canonical.com>,
LKML <linux-kernel@vger.kernel.org>,
John Stultz <john.stultz@linaro.org>, Ted Ts'o <tytso@mit.edu>,
Jiri Slaby <jirislaby@gmail.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org
Subject: Re: [PATCH 3/3] checkpatch.pl: Add check for task comm references
Date: Mon, 16 May 2011 16:22:41 -0700 [thread overview]
Message-ID: <1305588161.2503.46.camel@Joe-Laptop> (raw)
In-Reply-To: <op.vvlj1vad3l0zgt@mnazarewicz-glaptop>
On Tue, 2011-05-17 at 01:11 +0200, Michal Nazarewicz wrote:
> On Tue, 17 May 2011 01:04:50 +0200, Joe Perches <joe@perches.com> wrote:
> > On Mon, 2011-05-16 at 14:34 -0700, David Rientjes wrote:
> >> On Mon, 16 May 2011, Michal Nazarewicz wrote:
> >> > > Now that accessing current->comm needs to be protected,
> >> > > +# check for current->comm usage
> >> > > + if ($line =~ /\b(?:current|task|tsk|t)\s*->\s*comm\b/) {
> >> > Not a checkpatch.pl expert but as far as I'm concerned, that looks
> >> reasonable.
> > You don't need (?: just (
> Yep, it's a micro-optimisation though.
True, but it's not the common style in checkpatch.
You could submit patches to add non-capture markers to other () uses.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-05-16 23:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-16 21:19 [PATCH 0/3] v4 Improve task->comm locking situation John Stultz
2011-05-16 21:19 ` [PATCH 1/3] comm: Introduce comm_lock seqlock to protect task->comm access John Stultz
2011-05-16 22:01 ` Jiri Slaby
2011-05-17 1:47 ` John Stultz
2011-05-18 0:28 ` KOSAKI Motohiro
2011-05-16 21:19 ` [PATCH 2/3] printk: Add %ptc to safely print a task's comm John Stultz
2011-05-16 21:54 ` Jiri Slaby
2011-05-16 23:10 ` John Stultz
2011-05-16 23:56 ` Joe Perches
2011-05-17 0:11 ` John Stultz
2011-05-17 7:21 ` Jiri Slaby
2011-05-18 0:32 ` KOSAKI Motohiro
2011-05-16 21:19 ` [PATCH 3/3] checkpatch.pl: Add check for task comm references John Stultz
2011-05-16 21:29 ` Michal Nazarewicz
2011-05-16 21:34 ` David Rientjes
2011-05-16 23:04 ` Joe Perches
2011-05-16 23:11 ` Michal Nazarewicz
2011-05-16 23:22 ` Joe Perches [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-05-17 20:47 [PATCH 0/3] v5 Improve task->comm locking situation John Stultz
2011-05-17 20:47 ` [PATCH 3/3] checkpatch.pl: Add check for task comm references John Stultz
2011-05-17 20:58 ` Jiri Slaby
2011-05-17 21:04 ` Michal Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305588161.2503.46.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=dave@linux.vnet.ibm.com \
--cc=jirislaby@gmail.com \
--cc=john.stultz@linaro.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mina86@mina86.com \
--cc=rientjes@google.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).