From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with ESMTP id D48696B0023 for ; Mon, 16 May 2011 20:11:55 -0400 (EDT) Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e37.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p4H08vUv004767 for ; Mon, 16 May 2011 18:08:57 -0600 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id p4H0Bl3V146762 for ; Mon, 16 May 2011 18:11:47 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p4GIBKwW018585 for ; Mon, 16 May 2011 12:11:20 -0600 Subject: Re: [PATCH 2/3] printk: Add %ptc to safely print a task's comm From: John Stultz In-Reply-To: <1305590200.2503.48.camel@Joe-Laptop> References: <1305580757-13175-1-git-send-email-john.stultz@linaro.org> <1305580757-13175-3-git-send-email-john.stultz@linaro.org> <4DD19D10.3000201@gmail.com> <1305587432.2915.57.camel@work-vm> <1305590200.2503.48.camel@Joe-Laptop> Content-Type: text/plain; charset="UTF-8" Date: Mon, 16 May 2011 17:11:43 -0700 Message-ID: <1305591103.2915.70.camel@work-vm> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Joe Perches Cc: Jiri Slaby , LKML , Ted Ts'o , KOSAKI Motohiro , David Rientjes , Dave Hansen , Andrew Morton , linux-mm@kvack.org On Mon, 2011-05-16 at 16:56 -0700, Joe Perches wrote: > On Mon, 2011-05-16 at 16:10 -0700, John Stultz wrote: > > On Mon, 2011-05-16 at 23:54 +0200, Jiri Slaby wrote: > > > > In my attempt to clean up unprotected comm access, I've noticed > > > > most comm access is done for printk output. To simplify correct > > > > locking in these cases, I've introduced a new %ptc format, > > > > which will print the corresponding task's comm. > > > > Example use: > > > > printk("%ptc: unaligned epc - sending SIGBUS.\n", current); > > > > diff --git a/lib/vsprintf.c b/lib/vsprintf.c > [] > > > > +static noinline_for_stack > > > Actually, why noinline? Did your previous version have there some > > > TASK_COMM_LEN buffer or anything on stack which is not there anymore? > > No, I was just following how almost all of the pointer() called > > functions were declared. > > But with two pointers and a long, I add more then ip6_string() has on > > the stack, which uses the same notation. > > But I can drop that bit if there's really no need for it. > > vsprintf can be recursive, I think you should keep it. Ok. I'll keep it then. Thanks! -john -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org