From: Mel Gorman <mgorman@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
Minchan Kim <minchan.kim@gmail.com>,
Thomas Sattler <tsattler@gmx.de>,
Ury Stankevich <urykhy@gmail.com>,
Andi Kleen <andi@firstfloor.org>, linux-mm <linux-mm@kvack.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH 0/4] Fix compaction stalls due to accounting errors in isolated page accounting
Date: Tue, 7 Jun 2011 16:07:01 +0100 [thread overview]
Message-ID: <1307459225-4481-1-git-send-email-mgorman@suse.de> (raw)
There were some reports about processes getting stalled for very long
periods of time in compaction. The bulk of this problem turned out
to be due to an accounting error wherby the isolated count could go
negative but only noticed by UP builds.
This series is the useful patches (not all mine) that came out of
the related discussions that have not been merged to -mm already.
All these patches should be considered for -stable 2.6.38 and
2.6.39. Hence, Andrea's introduction of __page_count() is missing from
this series because while it's worth merging, it's not for -stable.
Patch 1 is the primary fix for a problem where the isolated count
could go negative on one zone and remain elevated on another.
Patch 2 notes that the linear scanner in vmscan.c cannot safely
use page_count because it could be scanning a tail page.
Patch 3 fixes memory failure accounting of isolated pages
Patch 4 fixes a problem whereby asynchronous callers to compaction
can still stall in too_many_isolated when it should just fail
the allocation.
Re-verification from testers that these patches really do fix their
problems would be appreciated. Even if hangs disappear, please confirm
that the values for nr_isolated_anon and nr_isolated_file in *both*
/proc/zoneinfo and /proc/vmstat are sensible (i.e. usually zero).
mm/compaction.c | 41 +++++++++++++++++++++++++++++++++++------
mm/memory-failure.c | 4 +++-
mm/vmscan.c | 16 ++++++++++++++--
3 files changed, 52 insertions(+), 9 deletions(-)
--
1.7.3.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2011-06-07 15:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 15:07 Mel Gorman [this message]
2011-06-07 15:07 ` [PATCH 1/4] mm: compaction: Ensure that the compaction free scanner does not move to the next zone Mel Gorman
2011-06-08 9:33 ` Michal Hocko
2011-06-07 15:07 ` [PATCH 2/4] mm: vmscan: Do not use page_count without a page pin Mel Gorman
2011-06-07 15:12 ` Minchan Kim
2011-06-08 9:38 ` Michal Hocko
2011-06-07 15:07 ` [PATCH 3/4] mm: memory-failure: Fix isolated page count during memory failure Mel Gorman
2011-06-07 15:14 ` Minchan Kim
2011-06-08 10:07 ` Michal Hocko
2011-06-08 10:11 ` Michal Hocko
2011-06-07 15:07 ` [PATCH 4/4] mm: compaction: Abort compaction if too many pages are isolated and caller is asynchronous Mel Gorman
2011-06-07 15:50 ` Minchan Kim
2011-06-07 16:26 ` Mel Gorman
2011-06-07 16:27 ` [PATCH 4/4] mm: compaction: Abort compaction if too many pages are isolated and caller is asynchronous V2 Mel Gorman
2011-06-07 16:36 ` Minchan Kim
2011-06-08 9:55 ` Michal Hocko
2011-07-17 8:52 ` [PATCH 0/4] Fix compaction stalls due to accounting errors in isolated page accounting Thomas Sattler
2011-07-19 9:16 ` Mel Gorman
2011-07-19 11:24 ` Thomas Sattler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307459225-4481-1-git-send-email-mgorman@suse.de \
--to=mgorman@suse.de \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=tsattler@gmx.de \
--cc=urykhy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).