From: Matt Mackall <mpm@selenic.com>
To: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Cc: Christoph Lameter <cl@linux-foundation.org>,
Pekka Enberg <penberg@kernel.org>,
linux-mm@kvack.org, "David S. Miller" <davem@davemloft.net>,
netfilter@vger.kernel.org
Subject: Re: [PATCH] slob: push the min alignment to long long
Date: Tue, 14 Jun 2011 17:05:40 -0500 [thread overview]
Message-ID: <1308089140.15617.221.camel@calx> (raw)
In-Reply-To: <20110614201031.GA19848@Chamillionaire.breakpoint.cc>
On Tue, 2011-06-14 at 22:10 +0200, Sebastian Andrzej Siewior wrote:
> In SLOB ARCH_KMALLOC_MINALIGN is 4 on 32bit platforms by default. On
> powerpc and some other architectures except x86 the default alignment of
> u64 is 8. The leads to __alignof__(struct ipt_entry) being 8 instead of 4
> which is enforced by SLOB.
Ok, so you claim that ARCH_KMALLOC_MINALIGN is not set on some
architectures, and thus SLOB does the wrong thing.
Doesn't that rather obviously mean that the affected architectures
should define ARCH_KMALLOC_MINALIGN? Because, well, they have an
"architecture-specific minimum kmalloc alignment"?
This change will regress SLOB everywhere where '4' was the right answer.
--
Mathematics is the supreme nostalgia of our time.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-06-14 22:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 20:10 [PATCH] slob: push the min alignment to long long Sebastian Andrzej Siewior
2011-06-14 20:40 ` Christoph Lameter
2011-06-14 21:16 ` Christoph Lameter
2011-06-15 20:06 ` Sebastian Andrzej Siewior
2011-06-16 16:48 ` Pekka Enberg
2011-06-22 23:41 ` David Rientjes
2011-06-23 14:36 ` Christoph Lameter
2011-06-23 20:24 ` David Rientjes
2011-06-14 22:05 ` Matt Mackall [this message]
2011-06-15 20:12 ` Sebastian Andrzej Siewior
2011-06-15 20:24 ` Matt Mackall
2011-06-15 20:40 ` Pekka Enberg
2011-06-15 20:55 ` Matt Mackall
2011-06-15 22:11 ` David Miller
2011-06-15 22:53 ` Matt Mackall
2011-06-16 6:59 ` Pekka Enberg
2011-06-16 15:23 ` Matt Mackall
2011-06-16 15:28 ` Pekka Enberg
2011-06-15 22:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308089140.15617.221.camel@calx \
--to=mpm@selenic.com \
--cc=cl@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-mm@kvack.org \
--cc=netfilter@vger.kernel.org \
--cc=penberg@kernel.org \
--cc=sebastian@breakpoint.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).