From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta12.messagelabs.com (mail6.bemta12.messagelabs.com [216.82.250.247]) by kanga.kvack.org (Postfix) with ESMTP id 046FC900225 for ; Fri, 24 Jun 2011 09:43:24 -0400 (EDT) From: Mel Gorman Subject: [PATCH 3/4] mm: vmscan: Evaluate the watermarks against the correct classzone Date: Fri, 24 Jun 2011 14:43:17 +0100 Message-Id: <1308922998-15529-4-git-send-email-mgorman@suse.de> In-Reply-To: <1308922998-15529-1-git-send-email-mgorman@suse.de> References: <1308922998-15529-1-git-send-email-mgorman@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: =?UTF-8?q?P=C3=A1draig=20Brady?= , James Bottomley , Colin King , Minchan Kim , Andrew Lutomirski , Rik van Riel , Johannes Weiner , linux-mm , linux-kernel , Mel Gorman When deciding if kswapd is sleeping prematurely, the classzone is taken into account but this is different to what balance_pgdat() and the allocator are doing. Specifically, the DMA zone will be checked based on the classzone used when waking kswapd which could be for a GFP_KERNEL or GFP_HIGHMEM request. The lowmem reserve limit kicks in, the watermark is not met and kswapd thinks its sleeping prematurely keeping kswapd awake in error. Reported-and-tested-by: PA!draig Brady Signed-off-by: Mel Gorman --- mm/vmscan.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 38665ec..d859111 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2341,7 +2341,7 @@ static bool sleeping_prematurely(pg_data_t *pgdat, int order, long remaining, } if (!zone_watermark_ok_safe(zone, order, high_wmark_pages(zone), - classzone_idx, 0)) + i, 0)) all_zones_ok = false; else balanced += zone->present_pages; -- 1.7.3.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org