From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta8.messagelabs.com (mail6.bemta8.messagelabs.com [216.82.243.55]) by kanga.kvack.org (Postfix) with ESMTP id 4BCA46B004A for ; Mon, 11 Jul 2011 06:33:19 -0400 (EDT) Subject: Re: [PATCH] Remove incorrect usage of sysctl_vfs_cache_pressure From: Steven Whitehouse In-Reply-To: <20110711020054.GE23038@dastard> References: <20110711020054.GE23038@dastard> Content-Type: text/plain; charset="UTF-8" Date: Mon, 11 Jul 2011 11:35:11 +0100 Message-ID: <1310380511.2766.3.camel@menhir> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org List-ID: To: Dave Chinner Cc: raghu.prabhu13@gmail.com, akpm@linux-foundation.org, mgorman@suse.de, kamezawa.hiroyu@jp.fujitsu.com, keithp@keithp.com, viro@zeniv.linux.org.uk, riel@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, jack@suse.cz, Raghavendra D Prabhu Hi, On Mon, 2011-07-11 at 12:00 +1000, Dave Chinner wrote: > On Mon, Jul 11, 2011 at 02:56:23AM +0530, raghu.prabhu13@gmail.com wrote: > > From: Raghavendra D Prabhu > > > > In shrinker functions, sysctl_vfs_cache_pressure variable is being used while > > trimming slab caches in general and not restricted to inode/dentry caches as > > documented for that sysctl. > > > > Raghavendra D Prabhu (1): > > mm/vmscan: Remove sysctl_vfs_cache_pressure from non-vfs shrinkers > > > > drivers/gpu/drm/i915/i915_gem.c | 2 +- > > That's the only questionable use of it as it has nothing to do with > filesystems. > > > fs/gfs2/glock.c | 2 +- > > fs/gfs2/quota.c | 2 +- > > fs/mbcache.c | 2 +- > > fs/nfs/dir.c | 2 +- > > fs/quota/dquot.c | 3 +-- > > net/sunrpc/auth.c | 2 +- > > All the others are filesystema??specific caches and as such the use of > vfs_cache_pressure to adjust the balance of reclaim is valid usage. > Especially the VFS quota cache shrinkers. ;) > > Cheers, > > Dave. I agree for the two GFS2 uses of this variable. There is no need to make this change, Steve. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org