linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	linux-mm@kvack.org
Subject: Re: select_task_rq_fair: WARNING: at kernel/lockdep.c match_held_lock
Date: Thu, 04 Aug 2011 17:57:53 +0200	[thread overview]
Message-ID: <1312473473.16729.44.camel@twins> (raw)
In-Reply-To: <20110804155347.GB3562@swordfish.minsk.epam.com>

On Thu, 2011-08-04 at 18:53 +0300, Sergey Senozhatsky wrote:
> On (08/04/11 17:47), Peter Zijlstra wrote:
> > On Thu, 2011-08-04 at 18:37 +0300, Sergey Senozhatsky wrote:
> > > > > [  132.794685] WARNING: at kernel/lockdep.c:3117 match_held_lock+0xf6/0x12e()
> > 
> > Just to double check, that line is:
> > 
> >                 if (DEBUG_LOCKS_WARN_ON(!hlock->nest_lock))
> > 
> > in your kernel source?
> > 
> 
> Nope, that's `if (DEBUG_LOCKS_WARN_ON(!class))'
> 
> 3106 static int match_held_lock(struct held_lock *hlock, struct lockdep_map *lock)
> 3107 {                                                                                                                                                                                                                             
> 3108     if (hlock->instance == lock)
> 3109         return 1;
> 3110 
> 3111     if (hlock->references) {
> 3112         struct lock_class *class = lock->class_cache[0];
> 3113 
> 3114         if (!class)
> 3115             class = look_up_lock_class(lock, 0);
> 3116 
> 3117         if (DEBUG_LOCKS_WARN_ON(!class))
> 3118             return 0;
> 3119 
> 3120         if (DEBUG_LOCKS_WARN_ON(!hlock->nest_lock))
> 3121             return 0;
> 3122 
> 3123         if (hlock->class_idx == class - lock_classes + 1)
> 3124             return 1;
> 3125     }
> 3126 
> 3127     return 0;
> 3128 }
> 3129 

Ah, in that case my previous analysis was pointless and I shall need to
scratch my head some more. 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-08-04 15:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-04 14:13 select_task_rq_fair: WARNING: at kernel/lockdep.c match_held_lock Sergey Senozhatsky
2011-08-04 15:05 ` Peter Zijlstra
2011-08-04 15:13   ` Peter Zijlstra
2011-08-04 15:37   ` Sergey Senozhatsky
2011-08-04 15:47     ` Peter Zijlstra
2011-08-04 15:53       ` Sergey Senozhatsky
2011-08-04 15:57         ` Peter Zijlstra [this message]
2011-08-04 16:04           ` Sergey Senozhatsky
2011-08-05 12:36         ` Peter Zijlstra
2011-08-05 15:27           ` Sergey Senozhatsky
2011-08-06 19:39           ` Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1312473473.16729.44.camel@twins \
    --to=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@elte.hu \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).