Re: [PATCH 5/5] writeback: IO-less balance_dirty_pages()

Vivek Goyal
2011-08-09T19:16:38Z

On Sat, Aug 06, 2011 at 04:44:52PM +0800, Wu Fengguang wrote:

[..]
> -/*
> - * task_dirty_limit - scale down dirty throttling threshold for one task
> - *
> - * task specific dirty limit:
> - *
> - * dirty -= (dirty/8) * p_{t}
> - *
> - * To protect light/slow dirtying tasks from heavier/fast ones, we start
> - * throttling individual tasks before reaching the bdi dirty limit.
> - * Relatively low thresholds will be allocated to heavy dirtiers. So when
> - * dirty pages grow large, heavy dirtiers will be throttled first, which will
> - * effectively curb the growth of dirty pages. Light dirtiers with high enough
> - * dirty threshold may never get throttled.
> - */

Hi Fengguang,

So we have got rid of the notion of per task dirty limit based on their
fraction? What replaces it.

I can't see any code which is replacing it. If yes, I am wondering how
do you get fairness among tasks which share this bdi.

Also wondering what did this patch series to do make sure that tasks
share bdi more fairly and get write_bw/N bandwidth.

Thanks
Vivek