Re: [PATCH 4/5] writeback: per task dirty rate limit

Wu Fengguang
2011-08-16T07:22:56Z

> > + if (!bdi->dirty_exceeded)
> > + ratelimit = current->nr_dirtied_pause;
> > + else
> > + ratelimit = min(ratelimit, 32 >> (PAGE_SHIFT - 10));
>
> Usage of ratelimit before init?
>
> Maybe:
>
> ratelimit = current->nr_dirtied_pause;
> if (bdi->dirty_exceeded)
> ratelimit = min(ratelimit, 32 >> (PAGE_SHIFT - 10));

Good catch, thanks! That's indeed the original form. I changed it to
make the code more aligned...

Thanks,
Fengguang