From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with ESMTP id 8DE08900137 for ; Tue, 9 Aug 2011 12:19:56 -0400 (EDT) Subject: Re: [PATCH 3/5] writeback: dirty rate control From: Peter Zijlstra Date: Tue, 09 Aug 2011 18:19:32 +0200 In-Reply-To: <1312906591.1083.43.camel@twins> References: <20110806084447.388624428@intel.com> <20110806094526.878435971@intel.com> <20110809155046.GD6482@redhat.com> <1312906591.1083.43.camel@twins> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Message-ID: <1312906772.1083.45.camel@twins> Mime-Version: 1.0 Sender: owner-linux-mm@kvack.org List-ID: To: Vivek Goyal Cc: Wu Fengguang , linux-fsdevel@vger.kernel.org, Andrew Morton , Jan Kara , Christoph Hellwig , Dave Chinner , Greg Thelen , Minchan Kim , Andrea Righi , linux-mm , LKML On Tue, 2011-08-09 at 18:16 +0200, Peter Zijlstra wrote: > On Tue, 2011-08-09 at 11:50 -0400, Vivek Goyal wrote: > >=20 > > So IIUC, bdi->dirty_ratelimit is the dynmically adjusted desired rate > > limit (based on postion ratio, dirty_bw and write_bw). But this seems > > to be overall bdi limit and does not seem to take into account the > > number of tasks doing IO to that bdi (as your comment suggests). So > > it probably will track write_bw as opposed to write_bw/N. What am > > I missing?=20 >=20 > I think the per task thing comes from him using the pages_dirtied > argument to balance_dirty_pages() to compute the sleep time. Although > I'm not quite sure how he keeps fairness in light of the sleep time > bounding to MAX_PAUSE. Furthermore, there's of course the issue that current->nr_dirtied is computed over all BDIs it dirtied pages from, and the sleep time is computed for the BDI it happened to do the overflowing write on. Assuming an task (mostly) writes to a single bdi, or equally to all, it should all work out. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org