From: Akinobu Mita <akinobu.mita@gmail.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org
Cc: Akinobu Mita <akinobu.mita@gmail.com>
Subject: [PATCH 1/4] debug-pagealloc: use plain __ratelimit() instead of printk_ratelimit()
Date: Tue, 23 Aug 2011 01:29:05 +0900 [thread overview]
Message-ID: <1314030548-21082-2-git-send-email-akinobu.mita@gmail.com> (raw)
In-Reply-To: <1314030548-21082-1-git-send-email-akinobu.mita@gmail.com>
printk_ratelimit() should not be used, because it shares ratelimiting
state with all other unrelated printk_ratelimit() callsites.
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
---
mm/debug-pagealloc.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/mm/debug-pagealloc.c b/mm/debug-pagealloc.c
index a1e3324..a4b6d70 100644
--- a/mm/debug-pagealloc.c
+++ b/mm/debug-pagealloc.c
@@ -2,6 +2,7 @@
#include <linux/mm.h>
#include <linux/page-debug-flags.h>
#include <linux/poison.h>
+#include <linux/ratelimit.h>
static inline void set_page_poison(struct page *page)
{
@@ -59,6 +60,7 @@ static bool single_bit_flip(unsigned char a, unsigned char b)
static void check_poison_mem(unsigned char *mem, size_t bytes)
{
+ static DEFINE_RATELIMIT_STATE(ratelimit, 5 * HZ, 10);
unsigned char *start;
unsigned char *end;
@@ -74,7 +76,7 @@ static void check_poison_mem(unsigned char *mem, size_t bytes)
break;
}
- if (!printk_ratelimit())
+ if (!__ratelimit(&ratelimit))
return;
else if (start == end && single_bit_flip(*start, PAGE_POISON))
printk(KERN_ERR "pagealloc: single bit error\n");
--
1.7.4.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-08-22 16:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 16:29 [PATCH 0/4] debug-pagealloc improvements Akinobu Mita
2011-08-22 16:29 ` Akinobu Mita [this message]
2011-08-22 16:29 ` [PATCH 2/4] debug-pagealloc: add support for highmem pages Akinobu Mita
2011-08-22 20:43 ` Andrew Morton
2011-08-23 15:26 ` Akinobu Mita
2011-08-22 16:29 ` [PATCH 3/4] string: introduce memchr_inv Akinobu Mita
2011-08-22 16:57 ` Pekka Enberg
2011-08-22 17:09 ` Jörn Engel
2011-08-22 20:52 ` Andrew Morton
2011-08-22 21:50 ` Andrew Morton
2011-08-22 21:56 ` Eric Dumazet
2011-08-22 20:59 ` Geert Uytterhoeven
2011-08-23 14:31 ` Christoph Lameter
2011-08-22 16:29 ` [PATCH 4/4] debug-pagealloc: use memchr_inv Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314030548-21082-2-git-send-email-akinobu.mita@gmail.com \
--to=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).