From: Peter Zijlstra <peterz@infradead.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Christoph Lameter <cl@linux.com>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Thelen <gthelen@google.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Balbir Singh <bsingharora@gmail.com>,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
linux-arch@vger.kernel.org
Subject: Re: [PATCH] memcg: remove unneeded preempt_disable
Date: Fri, 26 Aug 2011 01:01:37 +0200 [thread overview]
Message-ID: <1314313297.26922.17.camel@twins> (raw)
In-Reply-To: <1314300546.3268.8.camel@mulgrave>
On Thu, 2011-08-25 at 12:29 -0700, James Bottomley wrote:
>
> Therefore from the risc point of view, most of the this_cpu_xxx
> operations are things that we don't really care about except that the
> result would be easier to read in C.
Right, so the current fallback case is pretty much the optimal case for
the RISC machines, which ends up with generic code being better off not
using it much and instead preferring __this_cpu if there's more than
one.
I mean, its absolutely awesome these things are 1 instruction on x86,
but if we pessimize all other 20-odd architectures its just not cool.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-08-25 23:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-18 6:50 [PATCH] memcg: remove unneeded preempt_disable Greg Thelen
2011-08-18 6:52 ` KAMEZAWA Hiroyuki
2011-08-18 9:38 ` Johannes Weiner
2011-08-18 14:26 ` Valdis.Kletnieks
2011-08-18 14:41 ` Johannes Weiner
2011-08-18 18:27 ` Valdis.Kletnieks
2011-08-18 21:40 ` Andrew Morton
2011-08-19 0:00 ` Greg Thelen
2011-08-25 14:57 ` Peter Zijlstra
2011-08-25 15:11 ` Christoph Lameter
2011-08-25 16:20 ` James Bottomley
2011-08-25 16:31 ` Christoph Lameter
2011-08-25 16:34 ` James Bottomley
2011-08-25 17:07 ` Christoph Lameter
2011-08-25 18:34 ` James Bottomley
2011-08-25 18:46 ` Christoph Lameter
2011-08-25 18:49 ` Peter Zijlstra
2011-08-25 18:53 ` Peter Zijlstra
2011-08-25 19:05 ` Peter Zijlstra
2011-08-25 19:19 ` Christoph Lameter
2011-08-25 22:56 ` Peter Zijlstra
2011-08-25 19:29 ` James Bottomley
2011-08-25 23:01 ` Peter Zijlstra [this message]
2011-08-25 18:40 ` Peter Zijlstra
2011-09-06 9:58 ` Johannes Weiner
2011-09-06 10:04 ` KAMEZAWA Hiroyuki
2011-09-06 10:49 ` Johannes Weiner
2011-09-06 10:45 ` KAMEZAWA Hiroyuki
2011-09-06 18:04 ` Greg Thelen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314313297.26922.17.camel@twins \
--to=peterz@infradead.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=bsingharora@gmail.com \
--cc=cl@linux.com \
--cc=gthelen@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).