From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with SMTP id 44634900137 for ; Mon, 29 Aug 2011 21:49:51 -0400 (EDT) Subject: Re: [patch 2/2]slub: add a type for slab partial list position From: Shaohua Li In-Reply-To: References: <1314059823.29510.19.camel@sli10-conroe> <1314147472.29510.25.camel@sli10-conroe> <1314587187.4523.55.camel@debian> Content-Type: text/plain; charset="UTF-8" Date: Tue, 30 Aug 2011 09:51:55 +0800 Message-ID: <1314669116.29510.45.camel@sli10-conroe> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Lameter Cc: "Shi, Alex" , Andrew Morton , linux-mm , lkml , "penberg@kernel.org" , "Chen, Tim C" On Mon, 2011-08-29 at 22:20 +0800, Christoph Lameter wrote: > On Mon, 29 Aug 2011, Alex,Shi wrote: > > > On Wed, 2011-08-24 at 08:57 +0800, Li, Shaohua wrote: > > > On Tue, 2011-08-23 at 23:25 +0800, Christoph Lameter wrote: > > > > On Tue, 23 Aug 2011, Shaohua Li wrote: > > > > > > > > > Adding slab to partial list head/tail is sensentive to performance. > > > > > So adding a type to document it to avoid we get it wrong. > > > > > > > > I think that if you want to make it more descriptive then using the stats > > > > values (DEACTIVATE_TO_TAIL/HEAD) would avoid having to introduce an > > > > additional enum and it would also avoid the if statement in the stat call. > > > ok, that's better. > > > > > > Subject: slub: explicitly document position of inserting slab to partial list > > > > > > Adding slab to partial list head/tail is sensitive to performance. > > > So explicitly uses DEACTIVATE_TO_TAIL/DEACTIVATE_TO_HEAD to document > > > it to avoid we get it wrong. > > > > Frankly speaking, using DEACTIVATE_TO_TAIL/DEACTIVATE_TO_HEAD in > > slab_alloc, slab_free make code hard to understand. Just adding some > > comments will be more clear and understandable. like the following: > > Do you think so? > > Yes, I like that more. fine, let me add it to the first patch -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org