From: Shaohua Li <shaohua.li@intel.com>
To: Christoph Lameter <cl@linux.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"penberg@kernel.org" <penberg@kernel.org>,
"Shi, Alex" <alex.shi@intel.com>,
"Chen, Tim C" <tim.c.chen@intel.com>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [patch 2/2]slub: explicitly document position of inserting slab to partial list
Date: Wed, 31 Aug 2011 10:29:48 +0800 [thread overview]
Message-ID: <1314757788.29510.59.camel@sli10-conroe> (raw)
In-Reply-To: <alpine.DEB.2.00.1108300848040.19226@router.home>
On Tue, 2011-08-30 at 21:48 +0800, Christoph Lameter wrote:
> On Tue, 30 Aug 2011, Shaohua Li wrote:
>
> > Adding slab to partial list head/tail is sensitive to performance. Using 0/1
> > can easily cause typo. So explicitly uses DEACTIVATE_TO_TAIL/DEACTIVATE_TO_HEAD
> > to document it to avoid we get it wrong.
>
> I dont think we want this patch anymore.
I do think using 0/1 isn't good. A more meaningful name is better to
avoid typo.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-08-31 2:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-30 1:54 [patch 2/2]slub: explicitly document position of inserting slab to partial list Shaohua Li
2011-08-30 13:48 ` Christoph Lameter
2011-08-31 2:29 ` Shaohua Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314757788.29510.59.camel@sli10-conroe \
--to=shaohua.li@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@intel.com \
--cc=cl@linux.com \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=tim.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).