* [PATCH 2/2] slub: reduce a variable in __slab_free()
@ 2011-09-09 9:12 Alex,Shi
2011-09-12 15:27 ` Christoph Lameter
0 siblings, 1 reply; 2+ messages in thread
From: Alex,Shi @ 2011-09-09 9:12 UTC (permalink / raw)
To: cl@linux.com, Pekka Enberg
Cc: linux-mm@kvack.org, akpm@linux-foundation.org, Chen, Tim C,
Huang, Ying
After the compxchg, the new.inuse are fixed in __slab_free as a local
variable, so we don't need a extra variable for it.
This patch is also base on 'slub/partial' head of penberg's tree.
Signed-off-by: Alex Shi <alex.shi@intel.com>
---
mm/slub.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/mm/slub.c b/mm/slub.c
index bca8eee..c1f803f 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -2452,7 +2452,6 @@ static void __slab_free(struct kmem_cache *s, struct page *page,
void *prior;
void **object = (void *)x;
int was_frozen;
- int inuse;
struct page new;
unsigned long counters;
struct kmem_cache_node *n = NULL;
@@ -2495,7 +2494,6 @@ static void __slab_free(struct kmem_cache *s, struct page *page,
}
}
- inuse = new.inuse;
} while (!cmpxchg_double_slab(s, page,
prior, counters,
@@ -2526,7 +2524,7 @@ static void __slab_free(struct kmem_cache *s, struct page *page,
*/
if (was_frozen)
stat(s, FREE_FROZEN);
- else if (unlikely(!inuse && n->nr_partial > s->min_partial))
+ else if (unlikely(!new.inuse && n->nr_partial > s->min_partial))
goto slab_empty;
spin_unlock_irqrestore(&n->list_lock, flags);
--
1.7.0
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] slub: reduce a variable in __slab_free()
2011-09-09 9:12 [PATCH 2/2] slub: reduce a variable in __slab_free() Alex,Shi
@ 2011-09-12 15:27 ` Christoph Lameter
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Lameter @ 2011-09-12 15:27 UTC (permalink / raw)
To: Alex,Shi
Cc: Pekka Enberg, linux-mm@kvack.org, akpm@linux-foundation.org,
Chen, Tim C, Huang, Ying
On Fri, 9 Sep 2011, Alex,Shi wrote:
> After the compxchg, the new.inuse are fixed in __slab_free as a local
> variable, so we don't need a extra variable for it.
True but its an easier read otherwise and the contents are extracted from
the 16 bit value into a long which is easier to handle for the compiler
later. Check to see if there is a code difference due to this patch.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-12 15:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-09 9:12 [PATCH 2/2] slub: reduce a variable in __slab_free() Alex,Shi
2011-09-12 15:27 ` Christoph Lameter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).