* [PATCH] fix find_next_system_ram comments
@ 2011-09-26 13:58 Wizard
2011-09-26 16:58 ` Randy Dunlap
2011-09-28 0:52 ` KAMEZAWA Hiroyuki
0 siblings, 2 replies; 5+ messages in thread
From: Wizard @ 2011-09-26 13:58 UTC (permalink / raw)
To: linux-kernel, kamezawa.hiroyu; +Cc: linux-mm, Wizard
The purpose of find_next_system_ram() is to find a the lowest
memory resource which contain or overlap the [res->start, res->end),
not just contain.
In this patch, I make this comment more exact and fix one typo.
Signed-off-by: Wizard <wizarddewhite@gmail.com>
---
kernel/resource.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/kernel/resource.c b/kernel/resource.c
index 3b3cedc..2751a8c 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -279,7 +279,8 @@ EXPORT_SYMBOL(release_resource);
#if !defined(CONFIG_ARCH_HAS_WALK_MEMORY)
/*
- * Finds the lowest memory reosurce exists within [res->start.res->end)
+ * Finds the lowest memory resource which contains or overlaps
+ * [res->start.res->end)
* the caller must specify res->start, res->end, res->flags and "name".
* If found, returns 0, res is overwritten, if not found, returns -1.
*/
--
1.6.3.3
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] fix find_next_system_ram comments
2011-09-26 13:58 [PATCH] fix find_next_system_ram comments Wizard
@ 2011-09-26 16:58 ` Randy Dunlap
2011-09-28 0:52 ` KAMEZAWA Hiroyuki
1 sibling, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2011-09-26 16:58 UTC (permalink / raw)
To: Wizard; +Cc: linux-kernel, kamezawa.hiroyu, linux-mm
On 09/26/2011 06:58 AM, Wizard wrote:
> The purpose of find_next_system_ram() is to find a the lowest
> memory resource which contain or overlap the [res->start, res->end),
> not just contain.
>
> In this patch, I make this comment more exact and fix one typo.
>
> Signed-off-by: Wizard <wizarddewhite@gmail.com>
For Signed-off-by: Documentation/SubmittingPatches says:
using your real name (sorry, no pseudonyms or anonymous contributions.)
> ---
> kernel/resource.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/resource.c b/kernel/resource.c
> index 3b3cedc..2751a8c 100644
> --- a/kernel/resource.c
> +++ b/kernel/resource.c
> @@ -279,7 +279,8 @@ EXPORT_SYMBOL(release_resource);
>
> #if !defined(CONFIG_ARCH_HAS_WALK_MEMORY)
> /*
> - * Finds the lowest memory reosurce exists within [res->start.res->end)
> + * Finds the lowest memory resource which contains or overlaps
> + * [res->start.res->end)
Your patch description uses ", " (comma) here. I think that's better than
keeping the ".".
> * the caller must specify res->start, res->end, res->flags and "name".
> * If found, returns 0, res is overwritten, if not found, returns -1.
> */
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fix find_next_system_ram comments
2011-09-26 13:58 [PATCH] fix find_next_system_ram comments Wizard
2011-09-26 16:58 ` Randy Dunlap
@ 2011-09-28 0:52 ` KAMEZAWA Hiroyuki
1 sibling, 0 replies; 5+ messages in thread
From: KAMEZAWA Hiroyuki @ 2011-09-28 0:52 UTC (permalink / raw)
To: Wizard; +Cc: linux-kernel, linux-mm
On Mon, 26 Sep 2011 21:58:02 +0800
Wizard <wizarddewhite@gmail.com> wrote:
> The purpose of find_next_system_ram() is to find a the lowest
> memory resource which contain or overlap the [res->start, res->end),
> not just contain.
>
> In this patch, I make this comment more exact and fix one typo.
>
> Signed-off-by: Wizard <wizarddewhite@gmail.com>
Thank you for catching.
Please hear Randy's advice :)
> ---
> kernel/resource.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/resource.c b/kernel/resource.c
> index 3b3cedc..2751a8c 100644
> --- a/kernel/resource.c
> +++ b/kernel/resource.c
> @@ -279,7 +279,8 @@ EXPORT_SYMBOL(release_resource);
>
> #if !defined(CONFIG_ARCH_HAS_WALK_MEMORY)
> /*
> - * Finds the lowest memory reosurce exists within [res->start.res->end)
> + * Finds the lowest memory resource which contains or overlaps
> + * [res->start.res->end)
> * the caller must specify res->start, res->end, res->flags and "name".
> * If found, returns 0, res is overwritten, if not found, returns -1.
> */
> --
> 1.6.3.3
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] fix find_next_system_ram comments
@ 2011-09-27 14:02 Wizard
2011-09-28 4:36 ` KAMEZAWA Hiroyuki
0 siblings, 1 reply; 5+ messages in thread
From: Wizard @ 2011-09-27 14:02 UTC (permalink / raw)
To: linux-kernel, kamezawa.hiroyu, rdunlap; +Cc: linux-mm, Wizard
The purpose of find_next_system_ram() is to find a the lowest
memory resource which contain or overlap the [res->start, res->end),
not just contain.
In this patch, I make this comment more exact and fix one typo.
Signed-off-by: Wei Yang <wizarddewhite@gmail.com>
---
kernel/resource.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/kernel/resource.c b/kernel/resource.c
index 3b3cedc..8461aea 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -279,7 +279,8 @@ EXPORT_SYMBOL(release_resource);
#if !defined(CONFIG_ARCH_HAS_WALK_MEMORY)
/*
- * Finds the lowest memory reosurce exists within [res->start.res->end)
+ * Finds the lowest memory resource which contains or overlaps
+ * [res->start, res->end)
* the caller must specify res->start, res->end, res->flags and "name".
* If found, returns 0, res is overwritten, if not found, returns -1.
*/
--
1.6.3.3
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] fix find_next_system_ram comments
2011-09-27 14:02 Wizard
@ 2011-09-28 4:36 ` KAMEZAWA Hiroyuki
0 siblings, 0 replies; 5+ messages in thread
From: KAMEZAWA Hiroyuki @ 2011-09-28 4:36 UTC (permalink / raw)
To: Wizard; +Cc: linux-kernel, rdunlap, linux-mm
On Tue, 27 Sep 2011 22:02:04 +0800
Wizard <wizarddewhite@gmail.com> wrote:
> The purpose of find_next_system_ram() is to find a the lowest
> memory resource which contain or overlap the [res->start, res->end),
> not just contain.
>
> In this patch, I make this comment more exact and fix one typo.
>
> Signed-off-by: Wei Yang <wizarddewhite@gmail.com>
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-09-28 4:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-26 13:58 [PATCH] fix find_next_system_ram comments Wizard
2011-09-26 16:58 ` Randy Dunlap
2011-09-28 0:52 ` KAMEZAWA Hiroyuki
-- strict thread matches above, loose matches on Subject: below --
2011-09-27 14:02 Wizard
2011-09-28 4:36 ` KAMEZAWA Hiroyuki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).