From: Shaohua Li <shaohua.li@intel.com>
To: Andrew Morton <akpm@google.com>
Cc: Michal Hocko <mhocko@suse.cz>, linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch]mm: initialize zone all_unreclaimable
Date: Tue, 27 Sep 2011 09:10:11 +0800 [thread overview]
Message-ID: <1317085811.29510.180.camel@sli10-conroe> (raw)
In-Reply-To: <20110926155250.464e7770.akpm@google.com>
On Tue, 2011-09-27 at 06:52 +0800, Andrew Morton wrote:
> On Mon, 26 Sep 2011 15:23:20 +0200
> Michal Hocko <mhocko@suse.cz> wrote:
>
> > On Mon 26-09-11 16:11:52, Shaohua Li wrote:
> > > I saw DMA zone is always unreclaimable in my system.
> > > zone->all_unreclaimable isn't initialized till a page from the zone is
> > > freed. This isn't a big problem normally, but a little confused, so
> > > fix here.
> >
> > The value is initialized when a node is allocated. setup_node_data uses
> > alloc_remap which memsets the whole structure or memblock allocation
> > which is initialized to 0 as well AFAIK and memory hotplug uses
> > arch_alloc_nodedata which is kzalloc.
>
> setup_node_data() does memset(NODE_DATA(nid), 0, sizeof(pg_data_t)) just
> to be sure.
>
> However, Shaohua reports that "DMA zone is always unreclaimable in my system",
> and presumably this patch fixed it. So we don't know what's going on?
>
>
>
> Presumably all the other "zone->foo = 0" assignments in free_area_init_core()
> are unneeded.
Looks I didn't run my test correctly, sorry. I just check it, and this
is a vmscan bug, I'll work out a new patch.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-09-27 1:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 8:11 [patch]mm: initialize zone all_unreclaimable Shaohua Li
2011-09-26 13:23 ` Michal Hocko
2011-09-26 22:52 ` Andrew Morton
2011-09-27 1:10 ` Shaohua Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317085811.29510.180.camel@sli10-conroe \
--to=shaohua.li@intel.com \
--cc=akpm@google.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).