From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Joe Perches <joe@perches.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
rientjes@google.com, James.Bottomley@HansenPartnership.com,
hpa@zytor.com
Subject: Re: [RFCv3][PATCH 1/4] replace string_get_size() arrays
Date: Tue, 04 Oct 2011 13:51:06 -0700 [thread overview]
Message-ID: <1317761466.7842.41.camel@nimitz> (raw)
In-Reply-To: <1317760957.18210.15.camel@Joe-Laptop>
On Tue, 2011-10-04 at 13:42 -0700, Joe Perches wrote:
> > Right, but we're only handling u64.
>
> So the declaration should be:
>
> static const char byte_units[] = " KMGTPE";
I guess that's worth a comment. But that first character doesn't get
used. There were two alternatives:
static const char byte_units[] = "_KMGTPE";
or something along the lines of:
+ static const char byte_units[] = "KMGTPE";
...
+ index--;
+ /* index=-1 is plain 'B' with no other unit */
+ if (index >= 0) {
We don't ever _actually_ look at the space (or underscore). I figured
the _ was nicer since it would be _obvious_ if it ever got printed out
somehow.
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-10-04 20:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-01 0:08 [RFCv3][PATCH 1/4] replace string_get_size() arrays Dave Hansen
2011-10-01 0:08 ` [RFCv3][PATCH 2/4] add string_get_size_pow2() Dave Hansen
2011-10-01 0:08 ` [RFCv3][PATCH 3/4] add seq_print_pow2() function Dave Hansen
2011-10-01 0:09 ` [RFCv3][PATCH 4/4] show page size in /proc/$pid/numa_maps Dave Hansen
2011-10-05 6:50 ` David Rientjes
2011-10-05 7:09 ` Eric Dumazet
2011-10-05 7:23 ` David Rientjes
2011-10-05 8:54 ` Eric Dumazet
2011-10-05 19:19 ` David Rientjes
2011-10-05 15:22 ` Dave Hansen
2011-10-05 16:28 ` Eric Dumazet
2011-10-05 19:24 ` David Rientjes
2011-10-05 15:21 ` Dave Hansen
2011-10-01 19:29 ` [RFCv3][PATCH 1/4] replace string_get_size() arrays Joe Perches
2011-10-01 19:33 ` Joe Perches
2011-10-04 19:35 ` Dave Hansen
2011-10-04 20:42 ` Joe Perches
2011-10-04 20:51 ` Dave Hansen [this message]
2011-10-04 21:18 ` Joe Perches
2011-10-05 6:58 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317761466.7842.41.camel@nimitz \
--to=dave@linux.vnet.ibm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hpa@zytor.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).