From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28C6BC83F1A for ; Mon, 21 Jul 2025 14:42:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55B0D8E0005; Mon, 21 Jul 2025 10:42:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4BDFB8E0001; Mon, 21 Jul 2025 10:42:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3AC6D8E0005; Mon, 21 Jul 2025 10:42:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2C5088E0001 for ; Mon, 21 Jul 2025 10:42:21 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B44FD5B2E6 for ; Mon, 21 Jul 2025 14:42:20 +0000 (UTC) X-FDA: 83688537240.04.8B1C3C3 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by imf10.hostedemail.com (Postfix) with ESMTP id B1396C0002 for ; Mon, 21 Jul 2025 14:42:17 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=oI4S8zvx; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf10.hostedemail.com: domain of xiaoyao.li@intel.com designates 198.175.65.15 as permitted sender) smtp.mailfrom=xiaoyao.li@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1753108938; a=rsa-sha256; cv=none; b=KljP3fHURb3Q8K5vDKEk29ARmSSJ1nQHeq+040ZLwYOzDrpt2YSF57YgF7tUYLmVvnaVh2 m7GaX0rbZ2xWocSgkPheQUAI7XBkz8uGIV2MB3TCxIr3rsHhFkPQoZlBrIlNOApW/JThBg vMIGceqm18/AgWw1MEo3gJ3IpT9SGMU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=oI4S8zvx; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf10.hostedemail.com: domain of xiaoyao.li@intel.com designates 198.175.65.15 as permitted sender) smtp.mailfrom=xiaoyao.li@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1753108938; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vByDTvNOpnjs9SmTYXZItQx86dQby5Ok5jeLq6NAee8=; b=20EiWUcVRC4ozcDW0a/Buu4KdU/SVjMv8n0KWXLX5haAX/xTxaAQ01xRHQ3fnOOxLu+WXq bWhftJPowhCF8CP3DRtnTjLwUByPCECUCDuOX0XdSNDiPCC9qQ9hnlyIfx1FLXShfKwxbG xQ7dqQ56xdD3YLIToXJylLUSDb00z1Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1753108937; x=1784644937; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=fHFhQnz1d9jkIQy6+wvI0Utsmrj/cSx28cBy/0zuK7U=; b=oI4S8zvxfXW1EoffdJ8g7WI1Rx2Qkj9BfIj5I48LaxMl3bPcpT2j2zPX 6C84lnmN6VOLdD6KLte9tgNZuEez+hdOnUiNrvoXxjrqu72zdxgKESMgu HQ5D3w8OPwb/HTI4uxE4rV5YWI4Xg3u/zMTcGD1VxUDpSJpkenLSI0RKo 0MM3t3TOjLiVKI+0EnkyDpOGjB7BzWopd80h0ifJFwNwlzOk2Iocvg/vY T16VdOtII1/s1ooJyMWb12S1k2+XcRQcbLrjF0wCbLf3Jk08spobEGbYM PPlgD38PPBkWsDZehctl3JdZN8Pz2FlwzcGG46SgZNNN7px18Di0+gKfR g==; X-CSE-ConnectionGUID: L+rRWaYGSIundxYkB20Edg== X-CSE-MsgGUID: IPczvHDkQROwA5pOsd61TQ== X-IronPort-AV: E=McAfee;i="6800,10657,11499"; a="58985260" X-IronPort-AV: E=Sophos;i="6.16,329,1744095600"; d="scan'208";a="58985260" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2025 07:42:16 -0700 X-CSE-ConnectionGUID: qL0fP/21RrO2BIIqh5xu1g== X-CSE-MsgGUID: xd+ebKGrR4KwX8aDa1+/mA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,329,1744095600"; d="scan'208";a="159582796" Received: from xiaoyaol-hp-g830.ccr.corp.intel.com (HELO [10.124.247.1]) ([10.124.247.1]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2025 07:42:02 -0700 Message-ID: <131a3b2f-616f-428d-a41c-d490b9ca1b88@intel.com> Date: Mon, 21 Jul 2025 22:42:00 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v15 14/21] KVM: x86: Enable guest_memfd mmap for default VM type To: Vishal Annapurve Cc: Fuad Tabba , kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com References: <20250717162731.446579-1-tabba@google.com> <20250717162731.446579-15-tabba@google.com> <505a30a3-4c55-434c-86a5-f86d2e9dc78a@intel.com> Content-Language: en-US From: Xiaoyao Li In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: B1396C0002 X-Stat-Signature: waupidii3i63fr4hrjkx3guy54gq1rye X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1753108937-184468 X-HE-Meta: U2FsdGVkX18TDoagmPlkPEcivHRae94mnI+dKYMhx2qFwaqyVRAHDULp5bkCnXI2VcGacczyagCMqP44+KJpTujJKHCU32hSVhsJVyHKFl5L/8W2mMsrgZq5uzmIIx1052tDS0eWp3nDO6bPOxgzA+c1DzS86uWlNuNimrscWgNTOmZEEtywamINlfy0PBNE2zvL97JtIma2lW6q3mOBJXuyZQv9EE/I0x+VWkza9fPF34ctm9l3xHVUzOPmpu9lnUivaNg/dxGupBp8bD2kOZgnqTj9vavB6P9dAxgQw9I1vnKGn/8DVsOTAkLMZlD0wUn+RzLl2y9qukQ0z8D48Sk0DKT6PgbIXU+zZ1nzkJT5dn5g8ZCXghToCUIA8DKgmocGtGPfgYm85LyiSSYaivhVngz77aV/savRqUP8INGzBYfOxrst9CzzTcRZMwtX2quy9I3XT19jT3BENoPDXl19lzgWNO/iR+C6yIULKBT8L7pc7eAEiQbOlUpWRnJ9QI3A3GwH+8vtcGbf/9TZYILWIBV9Vo2Fnb8R8CN8y4fD53FMCtSkE7a7FwvGcMjQteceyHtzy06FWIRAQ1nGmlILejmYmnNokiv6iBw5x62zCktcONC+b83tihv2kV8sgRQLH47g3+OrqUpzobb5Jx+41ynnd/OiHKeFjM8iiF4ANJIMOReqkcFEB35IibUnO9Bqpe5cr8v3Ng4wwp1RinLNYJQU+JCKiUuwIn/B4PoTMd5MbXw2DOc0+KKx31yBfv5HhPSvucOIMNaIVES4qXA4OTEBm8QkMFRDzk3ZNIaECn82e/UmykNTPcZhPCMPpv/3fIHDzBeBcb4RrMX4KYIIb01gXXOAfhMmVSeKVyKVjyoD5uT9lIuUdVWMprBSV2oZCtGgeUQsUhcr21l+aQrsqqNNea0VFYDl2eEyq5lexIw/sfMv4NO81j1KMOQ7XE+FAUCK8LG0pZxvJRc P81KphjU Qj68Lrb1U+1tC0XB8RYppwtXZNOaFVJrKu+akZvHTXoJrDZ7Y6K8ERyOvvFbPsK/OSTJHoLQnHOkSQoRYpbd+6pfKq2TdBFO6v6i0Nb/tNmIbKHlka/Gq+usNcCkiAoJ6oXyoXmLvkpjlNa3ZZh//XywdVW1F1M2MT3WToV9CqRdCvZ7xdLT3773c2zJo7LTgrO/F29Y33c79qR/7P52liQOdhbwgz0KAAa/ZW973G+U8b2Lno8fBoUIm6hSzyDiVTr/BXew5ctrb8TUqUukf5ciEWNUVdhNEK0HEnoYXIETD5a/yxDe0+wsHf5tFIfrarWyX+Xayl4Dei6uxQht9F/2lbJ6ILe4pYyQMjsq/B0fjOUKzfxdwC5UPKvT2atDQ2+OG2RJiBksRuFmgs3fJQ1vBPg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/21/2025 9:45 PM, Vishal Annapurve wrote: > On Mon, Jul 21, 2025 at 5:22 AM Xiaoyao Li wrote: >> >> On 7/18/2025 12:27 AM, Fuad Tabba wrote: >>> +/* >>> + * CoCo VMs with hardware support that use guest_memfd only for backing private >>> + * memory, e.g., TDX, cannot use guest_memfd with userspace mapping enabled. >>> + */ >>> +#define kvm_arch_supports_gmem_mmap(kvm) \ >>> + (IS_ENABLED(CONFIG_KVM_GMEM_SUPPORTS_MMAP) && \ >>> + (kvm)->arch.vm_type == KVM_X86_DEFAULT_VM) >> >> I want to share the findings when I do the POC to enable gmem mmap in QEMU. >> >> Actually, QEMU can use gmem with mmap support as the normal memory even >> without passing the gmem fd to kvm_userspace_memory_region2.guest_memfd >> on KVM_SET_USER_MEMORY_REGION2. >> >> Since the gmem is mmapable, QEMU can pass the userspace addr got from >> mmap() on gmem fd to kvm_userspace_memory_region(2).userspace_addr. It >> works well for non-coco VMs on x86. >> >> Then it seems feasible to use gmem with mmap for the shared memory of >> TDX, and an additional gmem without mmap for the private memory. i.e., >> For struct kvm_userspace_memory_region, the @userspace_addr is passed >> with the uaddr returned from gmem0 with mmap, while @guest_memfd is >> passed with another gmem1 fd without mmap. >> >> However, it fails actually, because the kvm_arch_suports_gmem_mmap() >> returns false for TDX VMs, which means userspace cannot allocate gmem >> with mmap just for shared memory for TDX. > > Why do you want such a usecase to work? > > If kvm allows mappable guest_memfd files for TDX VMs without > conversion support, userspace will be able to use those for backing > private memory unless: > 1) KVM checks at binding time if the guest_memfd passed during memslot > creation is not a mappable one and doesn't enforce "not mappable" > requirement for TDX VMs at creation time. yes, this is the additional change required. > 2) KVM fetches shared faults through userspace page tables and not > guest_memfd directly. current KVM supports it already. And as I described above, current userspace can just mmap the gmem and pass the gotten addr to userspace_addr without passing guest_memfd, to force KVM to fetch through userspace page tables. So if we want KVM to fetch page from guest memfd directly, should we add something in KVM to enforce it? > I don't see value in trying to go out of way to support such a usecase. From my perspective, it's intuitive to think about this usecase when I tried to enable gmem mmap in QEMU. It seems a little strange that mmap'ed gmem can only serve as normal memory for non-CoCo VMs. If KVM mandates any gmem must be passed via kvm_userspace_memory_region2.guest_memfd, no matter it's mmap'ed or not, it would make more sense (to me) to not support such usecase, since there is only one guest_memfd field in struct kvm_userspace_memory_region2. At last, I just put it on the table, so people can be aware of it and make the call to support it or not. Either is OK to me.