From: Shaohua Li <shaohua.li@intel.com>
To: linux-mm <linux-mm@kvack.org>
Cc: penberg@kernel.org, cl@linux-foundation.org
Subject: [patch] slub: fix a code merge error
Date: Thu, 10 Nov 2011 16:04:20 +0800 [thread overview]
Message-ID: <1320912260.22361.247.camel@sli10-conroe> (raw)
Looks there is a merge error in the slub tree. DEACTIVATE_TO_TAIL != 1.
And this will cause performance regression.
Signed-off-by: Shaohua Li <shaohua.li@intel.com>
diff --git a/mm/slub.c b/mm/slub.c
index 7d2a996..60e16c4 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -1904,7 +1904,8 @@ static void unfreeze_partials(struct kmem_cache *s)
if (l == M_PARTIAL)
remove_partial(n, page);
else
- add_partial(n, page, 1);
+ add_partial(n, page,
+ DEACTIVATE_TO_TAIL);
l = m;
}
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2011-11-10 7:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-10 8:04 Shaohua Li [this message]
2011-11-10 14:44 ` [patch] slub: fix a code merge error Christoph Lameter
2011-11-10 20:18 ` David Rientjes
2011-11-10 20:30 ` Pekka Enberg
2011-11-11 0:33 ` Shaohua Li
2011-11-14 1:56 ` alex shi
2011-11-14 3:12 ` Shaohua Li
2011-11-15 6:45 ` Pekka Enberg
2011-11-16 23:06 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320912260.22361.247.camel@sli10-conroe \
--to=shaohua.li@intel.com \
--cc=cl@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).