linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, Mel Gorman <mgorman@suse.de>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Christoph Lameter <cl@linux-foundation.org>,
	Stanislaw Gruszka <sgruszka@redhat.com>
Subject: [PATCH v2 2/3] PM / Hibernate : do not count debug pages as savable
Date: Fri, 18 Nov 2011 17:25:06 +0100	[thread overview]
Message-ID: <1321633507-13614-2-git-send-email-sgruszka@redhat.com> (raw)
In-Reply-To: <1321633507-13614-1-git-send-email-sgruszka@redhat.com>

When debugging with CONFIG_DEBUG_PAGEALLOC and
debug_guardpage_minorder > 0, we have lot of free pages that are not
marked so. Snapshot code account them as savable, what cause hibernate
memory preallocation failure.

It is pretty hard to make hibernate allocation succeed with
debug_guardpage_minorder=1. This change at least make it possible when
system has relatively big amount of RAM.

v1 -> v2:
 - change "corrupt" name to guard page

Acked-by: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
---
 kernel/power/snapshot.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c
index cbe2c14..1cf8890 100644
--- a/kernel/power/snapshot.c
+++ b/kernel/power/snapshot.c
@@ -858,6 +858,9 @@ static struct page *saveable_highmem_page(struct zone *zone, unsigned long pfn)
 	    PageReserved(page))
 		return NULL;
 
+	if (page_is_guard(page))
+		return NULL;
+
 	return page;
 }
 
@@ -920,6 +923,9 @@ static struct page *saveable_page(struct zone *zone, unsigned long pfn)
 	    && (!kernel_page_present(page) || pfn_is_nosave(pfn)))
 		return NULL;
 
+	if (page_is_guard(page))
+		return NULL;
+
 	return page;
 }
 
-- 
1.7.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-11-18 16:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-18 16:25 [PATCH v2 1/3] mm: more intensive memory corruption debug Stanislaw Gruszka
2011-11-18 16:25 ` Stanislaw Gruszka [this message]
2011-11-18 16:25 ` [PATCH v3 3/3] slub: min order when debug_guardpage_minorder > 0 Stanislaw Gruszka
2011-11-21 17:15   ` Christoph Lameter
2011-12-07 22:07   ` David Rientjes
2011-12-08  7:33     ` Stanislaw Gruszka
2011-12-08 21:06       ` David Rientjes
2011-12-12 14:59         ` [PATCH -mm] slub: document setting min order with " Stanislaw Gruszka
2011-12-12 23:21           ` Rafael J. Wysocki
2011-12-14  0:41             ` David Rientjes
2011-12-16 13:21               ` Stanislaw Gruszka
2011-12-16 13:23                 ` [PATCH -mm] slub: debug_guardpage_minorder documentation tweak Stanislaw Gruszka
2011-12-16 21:16                   ` David Rientjes
2012-01-06 17:52                     ` David Rientjes
2011-11-22 21:56 ` [PATCH v2 1/3] mm: more intensive memory corruption debug Andrew Morton
2011-11-23 13:25   ` Stanislaw Gruszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321633507-13614-2-git-send-email-sgruszka@redhat.com \
    --to=sgruszka@redhat.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).