Re: WARNING: at mm/slub.c:3357, kernel BUG at mm/slub.c:3413

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

On Tue, 2011-11-22 at 00:39 -0800, Christian Kujau wrote:
> On Tue, 22 Nov 2011 at 08:48, Eric Dumazet wrote:
> > > --- linux-2.6.orig/mm/slub.c	2011-11-21 21:15:41.575673204 -0600
> > > +++ linux-2.6/mm/slub.c	2011-11-21 21:16:33.442336849 -0600
> > > @@ -1969,7 +1969,7 @@
> > >  		page->pobjects = pobjects;
> > >  		page->next = oldpage;
> > > 
> > > -	} while (this_cpu_cmpxchg(s->cpu_slab->partial, oldpage, page) != oldpage);
> > > +	} while (irqsafe_cpu_cmpxchg(s->cpu_slab->partial, oldpage, page) != oldpage);
> > >  	stat(s, CPU_PARTIAL_FREE);
> > >  	return pobjects;
> > >  }
> 
> Is this a patch to try for my PowerPC machine? With CONFIG_SLUB=y?
> 
> > For x86, I wonder if our !X86_FEATURE_CX16 support is correct on SMP
> > machines.
> 
> I'm on UP, don't have any x68/SMP machines to test atm :(

Yes, please try the patch with SLUB and let us know if it makes a
difference.

Eric, Christoph, the generic version of this_cpu_cmpxchg() is not
interrupt safe, so I suppose this patch should go in right ?

Cheers,
Ben.


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>