From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta8.messagelabs.com (mail6.bemta8.messagelabs.com [216.82.243.55]) by kanga.kvack.org (Postfix) with ESMTP id D490B6B00AB for ; Tue, 22 Nov 2011 17:16:46 -0500 (EST) Message-ID: <1322000195.14573.13.camel@pasglop> Subject: Re: WARNING: at mm/slub.c:3357, kernel BUG at mm/slub.c:3413 From: Benjamin Herrenschmidt Date: Wed, 23 Nov 2011 09:16:35 +1100 In-Reply-To: References: <20111121131531.GA1679@x4.trippels.de> <1321884966.10470.2.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> <20111121153621.GA1678@x4.trippels.de> <1321890510.10470.11.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> <20111121161036.GA1679@x4.trippels.de> <1321894353.10470.19.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> <1321895706.10470.21.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> <20111121173556.GA1673@x4.trippels.de> <1321900743.10470.31.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> <20111121185215.GA1673@x4.trippels.de> <20111121195113.GA1678@x4.trippels.de> <1321907275.13860.12.camel@pasglop> <1321948113.27077.24.camel@edumazet-laptop> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: owner-linux-mm@kvack.org List-ID: To: Christian Kujau Cc: Eric Dumazet , Christoph Lameter , Markus Trippelsdorf , "Alex,Shi" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , Pekka Enberg , Matt Mackall , "netdev@vger.kernel.org" , Tejun Heo On Tue, 2011-11-22 at 00:39 -0800, Christian Kujau wrote: > On Tue, 22 Nov 2011 at 08:48, Eric Dumazet wrote: > > > --- linux-2.6.orig/mm/slub.c 2011-11-21 21:15:41.575673204 -0600 > > > +++ linux-2.6/mm/slub.c 2011-11-21 21:16:33.442336849 -0600 > > > @@ -1969,7 +1969,7 @@ > > > page->pobjects = pobjects; > > > page->next = oldpage; > > > > > > - } while (this_cpu_cmpxchg(s->cpu_slab->partial, oldpage, page) != oldpage); > > > + } while (irqsafe_cpu_cmpxchg(s->cpu_slab->partial, oldpage, page) != oldpage); > > > stat(s, CPU_PARTIAL_FREE); > > > return pobjects; > > > } > > Is this a patch to try for my PowerPC machine? With CONFIG_SLUB=y? > > > For x86, I wonder if our !X86_FEATURE_CX16 support is correct on SMP > > machines. > > I'm on UP, don't have any x68/SMP machines to test atm :( Yes, please try the patch with SLUB and let us know if it makes a difference. Eric, Christoph, the generic version of this_cpu_cmpxchg() is not interrupt safe, so I suppose this patch should go in right ? Cheers, Ben. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org